scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN.json - Issue 1867293003: Revert of Revert "Remove references to crash_service, which is no longer needed."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN.json

Issue 1867293003: Revert of Revert "Remove references to crash_service, which is no longer needed." (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder__dbg_.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN__dbg_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN.json b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN.json

index 14d055f7cc797abca10203fffc7e08e337bba4c6..80a243984906ce0fb612966c383b38c2e7d9fba0 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_GN.json

@@ -260,8 +260,7 @@

"[BUILD]\\goma",

"--",

"browser_tests",

- "browser_tests_run",

- "crash_service"

+ "browser_tests_run"

"cwd": "[SLAVE_BUILD]",

"name": "compile",

@@ -331,17 +330,6 @@

"cmd": [

"python",

"-u",

- "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\chromium\\run_crash_handler.py",

- "--target",

- "Release_x64"

- ],

- "cwd": "[SLAVE_BUILD]",

- "name": "start_crash_service"

- },

- {

- "cmd": [

- "python",

- "-u",

"\nimport sys\nprint '*.isolated file for target %s is missing' % sys.argv[1]\nsys.exit(1)\n",

"browser_tests"