scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json - Issue 1867293003: Revert of Revert "Remove references to crash_service, which is no longer needed."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

Issue 1867293003: Revert of Revert "Remove references to crash_service, which is no longer needed." (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json ('k') | scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json b/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

index 7da90fb210831b228672f77a18e909bf03d9a6ec..cbef43094f8153e1abaa25d9842095c2ebdf56c9 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

@@ -259,7 +259,7 @@

"win_chromium_rel_ng",

"-v",

"//out/Release",

- "{\"additional_compile_targets\": [\"chromium_builder_tests\", \"crash_service\"], \"files\": [\"v8/foo.cc\"], \"test_targets\": [\"blink_heap_unittests\", \"blink_platform_unittests\", \"mini_installer\", \"webkit_unit_tests\", \"wtf_unittests\"]}",

+ "{\"additional_compile_targets\": [\"chromium_builder_tests\"], \"files\": [\"v8/foo.cc\"], \"test_targets\": [\"blink_heap_unittests\", \"blink_platform_unittests\", \"mini_installer\", \"webkit_unit_tests\", \"wtf_unittests\"]}",

"/path/to/tmp/json"

"cwd": "[SLAVE_BUILD]",

@@ -274,8 +274,7 @@

"@@@STEP_LOG_END@json.output@@@",

"@@@STEP_LOG_LINE@analyze_details@{@@@",

"@@@STEP_LOG_LINE@analyze_details@ \"additional_compile_targets\": [@@@",

- "@@@STEP_LOG_LINE@analyze_details@ \"chromium_builder_tests\", @@@",

- "@@@STEP_LOG_LINE@analyze_details@ \"crash_service\"@@@",

+ "@@@STEP_LOG_LINE@analyze_details@ \"chromium_builder_tests\"@@@",

"@@@STEP_LOG_LINE@analyze_details@ ], @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"compile_targets\": [], @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"self.m.filter.compile_targets\": [], @@@",

@@ -367,17 +366,6 @@

"cwd": "[SLAVE_BUILD]",

"name": "mark: before_tests"

- },

- {

- "cmd": [

- "python",

- "-u",

- "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\chromium\\run_crash_handler.py",

- "--target",

- "Release"

- ],

- "cwd": "[SLAVE_BUILD]",

- "name": "start_crash_service"

{

"cmd": [