scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json - Issue 1867293003: Revert of Revert "Remove references to crash_service, which is no longer needed."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json

Issue 1867293003: Revert of Revert "Remove references to crash_service, which is no longer needed." (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json b/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json

index 0be1cc3223d1d9acc979a69d2aacca3c10d70a6b..0ebbc2480eb97f19df9a9d043fe42e5ff40db7c2 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json

@@ -219,8 +219,7 @@

"--clobber",

"--",

"chrome",

- "chrome_official_builder_no_unittests",

- "crash_service"

+ "chrome_official_builder_no_unittests"

"cwd": "[SLAVE_BUILD]",

"name": "compile",

@@ -228,17 +227,6 @@

"@@@STEP_LOG_LINE@json.output (invalid)@null@@@",

"@@@STEP_LOG_END@json.output (invalid)@@@"

]

- },

- {

- "cmd": [

- "python",

- "-u",

- "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\chromium\\run_crash_handler.py",

- "--target",

- "Release"

- ],

- "cwd": "[SLAVE_BUILD]",

- "name": "start_crash_service"

{

"allow_subannotations": true,