Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1867263002: [generators] Store the resume mode in the generator object. (Closed)

Created:
4 years, 8 months ago by neis
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Store the resume mode in the generator object. ... instead of doing stack magic. This is a cleanup in preparation for the new generators implementation. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/2e3296666b04f0a038d9239a92e2ff39b5716f74 Cr-Commit-Position: refs/heads/master@{#35370}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Other platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -63 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M src/objects.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
neis
4 years, 8 months ago (2016-04-08 07:59:18 UTC) #1
neis
PTAL. Will do the other platforms if this looks okay.
4 years, 8 months ago (2016-04-08 08:13:52 UTC) #2
Benedikt Meurer
LGTM once comment addressed. https://codereview.chromium.org/1867263002/diff/1/src/x64/builtins-x64.cc File src/x64/builtins-x64.cc (right): https://codereview.chromium.org/1867263002/diff/1/src/x64/builtins-x64.cc#newcode484 src/x64/builtins-x64.cc:484: __ RecordWriteField(rbx, JSGeneratorObject::kResumeModeOffset, rdx, rcx, ...
4 years, 8 months ago (2016-04-08 10:20:14 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867263002/40001
4 years, 8 months ago (2016-04-08 13:01:10 UTC) #5
neis
On 2016/04/08 10:20:14, Benedikt Meurer wrote: > LGTM once comment addressed. > > https://codereview.chromium.org/1867263002/diff/1/src/x64/builtins-x64.cc > ...
4 years, 8 months ago (2016-04-08 13:01:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 13:25:53 UTC) #8
Benedikt Meurer
Still LGTM.
4 years, 8 months ago (2016-04-08 15:40:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867263002/40001
4 years, 8 months ago (2016-04-11 07:36:21 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-11 08:25:54 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 08:26:27 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/2e3296666b04f0a038d9239a92e2ff39b5716f74
Cr-Commit-Position: refs/heads/master@{#35370}

Powered by Google App Engine
This is Rietveld 408576698