Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1867253002: Convert //dbus from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
scheib, hashimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //dbus from scoped_ptr to std::unique_ptr BUG=554298 R=hashimoto@chromium.org TBR=scheib@chromium.org Committed: https://crrev.com/2a193281aac690b3fdfba1246d6b36877553a9be Cr-Commit-Position: refs/heads/master@{#386236}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Patch Set 3 : IWYU fixes in //device #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -208 lines) Patch
M dbus/bus.h View 1 chunk +1 line, -1 line 0 comments Download
M dbus/bus.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M dbus/bus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/dbus_statistics.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/end_to_end_async_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M dbus/end_to_end_sync_unittest.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M dbus/exported_object.h View 3 chunks +8 lines, -7 lines 0 comments Download
M dbus/exported_object.cc View 5 chunks +9 lines, -11 lines 0 comments Download
M dbus/file_descriptor.h View 2 chunks +3 lines, -2 lines 0 comments Download
M dbus/message.h View 3 chunks +8 lines, -6 lines 0 comments Download
M dbus/message.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M dbus/message_unittest.cc View 20 chunks +24 lines, -25 lines 0 comments Download
M dbus/mock_object_proxy.h View 1 1 chunk +11 lines, -10 lines 0 comments Download
M dbus/mock_unittest.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M dbus/object_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M dbus/object_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M dbus/object_proxy.h View 5 chunks +6 lines, -5 lines 0 comments Download
M dbus/object_proxy.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M dbus/object_proxy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/property.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M dbus/property_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M dbus/signal_sender_verification_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M dbus/test_service.cc View 13 chunks +21 lines, -21 lines 0 comments Download
M dbus/values_util.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M dbus/values_util_unittest.cc View 31 chunks +40 lines, -40 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_adapter_client.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_media_endpoint_service_provider.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_adapter_client.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
dcheng
This is largely a search and replace. There's probably some IWYU errors (files that don't ...
4 years, 8 months ago (2016-04-08 04:51:27 UTC) #2
hashimoto
https://codereview.chromium.org/1867253002/diff/1/dbus/mock_object_proxy.h File dbus/mock_object_proxy.h (right): https://codereview.chromium.org/1867253002/diff/1/dbus/mock_object_proxy.h#newcode25 dbus/mock_object_proxy.h:25: // scoped_ptr is scoped_ptr -> unique_ptr Also, please format ...
4 years, 8 months ago (2016-04-08 04:55:36 UTC) #3
dcheng
https://codereview.chromium.org/1867253002/diff/1/dbus/mock_object_proxy.h File dbus/mock_object_proxy.h (right): https://codereview.chromium.org/1867253002/diff/1/dbus/mock_object_proxy.h#newcode25 dbus/mock_object_proxy.h:25: // scoped_ptr is On 2016/04/08 at 04:55:36, hashimoto wrote: ...
4 years, 8 months ago (2016-04-08 05:02:02 UTC) #4
hashimoto
lgtm
4 years, 8 months ago (2016-04-08 06:05:52 UTC) #5
dcheng
TBR scheib for IWYU fixes in //device/bluetooth
4 years, 8 months ago (2016-04-08 21:53:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867253002/40001
4 years, 8 months ago (2016-04-08 21:54:11 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-08 22:55:13 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2a193281aac690b3fdfba1246d6b36877553a9be Cr-Commit-Position: refs/heads/master@{#386236}
4 years, 8 months ago (2016-04-08 22:57:04 UTC) #14
scheib
4 years, 8 months ago (2016-04-09 20:38:35 UTC) #15
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698