New Compilation API, part 1

New Compilation API, part 1

- Distinguish between context bound scripts (Script) and context unbound scripts
(UnboundScript).
- Add ScriptCompiler (which will later contain functions for async compilation).

This is a breaking change, in particular, Script::New no longer exists (it is
replaced by ScriptCompiler::CompileUnbound). Script::Compile remains as a
backwards-compatible shorthand for ScriptCompiler::Compile.

Passing CompilerOptions with produce_data_to_cache = true doesn't do anything
yet; the only way to generate the data to cache is the old preparsing API. (To
be fixed in the next version.)

BUG=
R=dcarney@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19881

[marja, 2014-03-10 14:12:35]

dcarney, svenpanne, ptal.

[dcarney, 2014-03-10 15:50:34]

https://codereview.chromium.org/186723005/diff/120001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1005
include/v8.h:1005: class V8_EXPORT ContextUnboundScript {
maybe just UnboundScript?

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1010
include/v8.h:1010: Local<Script> BindToGlobalContext();
should be bindtocurrentcontext

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1015
include/v8.h:1015: Local<Value> Run();
i don't think this should be here

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1054
include/v8.h:1054: int GetId() {
can we deprecate any of these?

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1119
include/v8.h:1119: struct V8_EXPORT CompileOptions {
an enum should be enough here, with kNoCompileOptions being the default

https://codereview.chromium.org/186723005/diff/120001/src/api.h
File src/api.h (right):

https://codereview.chromium.org/186723005/diff/120001/src/api.h#newcode186
src/api.h:186: V(Script, Object)                            \
JSFunction

https://codereview.chromium.org/186723005/diff/120001/src/api.h#newcode187
src/api.h:187: V(ContextUnboundScript, Object)              \
can this not be SharedFunctionInfo?

[marja, 2014-03-10 17:58:05]

Thanks for comments!

https://codereview.chromium.org/186723005/diff/120001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1005
include/v8.h:1005: class V8_EXPORT ContextUnboundScript {
On 2014/03/10 15:50:35, dcarney wrote:
> maybe just UnboundScript?

Done.

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1010
include/v8.h:1010: Local<Script> BindToGlobalContext();
On 2014/03/10 15:50:35, dcarney wrote:
> should be bindtocurrentcontext

Done.

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1015
include/v8.h:1015: Local<Value> Run();
On 2014/03/10 15:50:35, dcarney wrote:
> i don't think this should be here

This helper was doing BindToCurrentContext()->Run();, but removed it now..

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1054
include/v8.h:1054: int GetId() {
On 2014/03/10 15:50:35, dcarney wrote:
> can we deprecate any of these?

GetId is the only one used by chromium -> deprecated the other 2.

... or do we want to remove them instead? (This is a breaking API change
anyway.)

https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1119
include/v8.h:1119: struct V8_EXPORT CompileOptions {
On 2014/03/10 15:50:35, dcarney wrote:
> an enum should be enough here, with kNoCompileOptions being the default

Done.

https://codereview.chromium.org/186723005/diff/120001/src/api.h
File src/api.h (right):

https://codereview.chromium.org/186723005/diff/120001/src/api.h#newcode186
src/api.h:186: V(Script, Object)                            \
On 2014/03/10 15:50:35, dcarney wrote:
> JSFunction

Done.

https://codereview.chromium.org/186723005/diff/120001/src/api.h#newcode187
src/api.h:187: V(ContextUnboundScript, Object)              \
On 2014/03/10 15:50:35, dcarney wrote:
> can this not be SharedFunctionInfo?

Done.

[marja, 2014-03-11 10:51:13]

svenpanne, could you have a look? dcarney@ this LGTH, and he wanted you to ACK
the naming and such.

[dcarney, 2014-03-12 08:22:35]

lgtm

[marja, 2014-03-12 08:50:21]

(mstarzinger, fyi)

[marja, 2014-03-12 08:55:12]

Thanks for review!

I added back one function, Script::Compile(Handle<String>, Handle<String>)
because Chromium use it atm.

[marja, 2014-03-13 08:54:22]

Committed patchset #6 manually as r19881 (presubmit successful).