Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1867223005: Removed old AppContainer support. (Closed)

Created:
4 years, 8 months ago by forshaw
Modified:
4 years, 8 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org, jschuh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed old AppContainer support. This patch removes the old unused AppContainer support from the Windows sandbox. BUG=601735 BUG=476708 Committed: https://crrev.com/e83b4ce4a7ea0fef9538a6c10a50c82ab4b487d8 Cr-Commit-Position: refs/heads/master@{#386126}

Patch Set 1 #

Patch Set 2 : Fix clang warning and fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -566 lines) Patch
M sandbox/win/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M sandbox/win/sandbox_win.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
D sandbox/win/src/app_container.h View 1 chunk +0 lines, -69 lines 0 comments Download
D sandbox/win/src/app_container.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M sandbox/win/src/app_container_test.cc View 1 2 chunks +10 lines, -124 lines 0 comments Download
D sandbox/win/src/app_container_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M sandbox/win/src/broker_services.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/win/src/broker_services.cc View 5 chunks +0 lines, -40 lines 0 comments Download
M sandbox/win/src/sandbox.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sandbox/win/src/sandbox_policy.h View 1 chunk +0 lines, -11 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.h View 4 chunks +0 lines, -5 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 6 chunks +0 lines, -55 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
forshaw
As requested, removed the old AC support. PTAL.
4 years, 8 months ago (2016-04-08 15:31:57 UTC) #2
Will Harris
lgtm. looks like bugs 419104 and 476708 can be updated too
4 years, 8 months ago (2016-04-08 16:53:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867223005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867223005/20001
4 years, 8 months ago (2016-04-08 17:02:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 18:03:57 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 18:05:02 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e83b4ce4a7ea0fef9538a6c10a50c82ab4b487d8
Cr-Commit-Position: refs/heads/master@{#386126}

Powered by Google App Engine
This is Rietveld 408576698