Support audio in curtain mode, and use endpoint volume instead of session volume to adjust audio st…

Support audio in curtain mode, and use endpoint volume instead of session volume to adjust audio stream

BUG=597320, 242312
Committed: https://crrev.com/fc96e4f848fb4cca37e2da244dc873c1831d70c5
Cr-Commit-Position: refs/heads/master@{#386497}

[Hzj_jie, 2016-04-08 17:37:23]

zijiehe@chromium.org changed reviewers:
+ joedow@chromium.org, sergeyu@chromium.org

[Hzj_jie, 2016-04-08 17:37:23]

This change is to enable audio in curtain mode. As far as I can tell, in curtain
mode, AUDCLNT_BUFFERFLAGS_SILENT will always be set. The reason I can imagine
is, the samples won't be sent to hardware (earphones or speakers).

[Sergey Ulanov, 2016-04-11 17:58:01]

Does audio play back properly with this change? We disabled audio under RDP
because it wasn't working properly, see crbug.com/242312.

https://codereview.chromium.org/1867213002/diff/1/remoting/host/audio_capture...
File remoting/host/audio_capturer_win.cc (right):

https://codereview.chromium.org/1867213002/diff/1/remoting/host/audio_capture...
remoting/host/audio_capturer_win.cc:51: audio_client_->Stop();
if (audio_client_)

Is it necessary to call Stop() given that the object is going to be deleted?

https://codereview.chromium.org/1867213002/diff/1/remoting/host/audio_capture...
remoting/host/audio_capturer_win.cc:202: nullptr,
This parameter can fit on the previous line. clang-format please.

https://codereview.chromium.org/1867213002/diff/1/remoting/host/audio_capture...
remoting/host/audio_capturer_win.cc:259: // So we need to manually append volume
signal to the samples.
s/append volume signal/apply volume/

[Hzj_jie, 2016-04-11 21:33:35]

Description was changed from

==========
Support audio in curtain mode, and use endpoint volume instead of session volume
to adjust audio stream


BUG=597320
==========

to

==========
Support audio in curtain mode, and use endpoint volume instead of session volume
to adjust audio stream


BUG=597320,242312
==========

[Hzj_jie, 2016-04-11 21:37:23]

I have tried this change on my machine with curtain mode on. And the audio
quality is on-par with non-curtain mode.

https://codereview.chromium.org/1867213002/diff/1/remoting/host/audio_capture...
File remoting/host/audio_capturer_win.cc (right):

https://codereview.chromium.org/1867213002/diff/1/remoting/host/audio_capture...
remoting/host/audio_capturer_win.cc:51: audio_client_->Stop();
On 2016/04/11 17:58:01, Sergey Ulanov wrote:
> if (audio_client_)
> 
> Is it necessary to call Stop() given that the object is going to be deleted?

I did not see a clear comment on MSDN to imply IAudioClient::~IAudioClient would
call Stop automatically, so I prefer to call Stop to avoid any potential leak.

Done.

https://codereview.chromium.org/1867213002/diff/1/remoting/host/audio_capture...
remoting/host/audio_capturer_win.cc:202: nullptr,
On 2016/04/11 17:58:01, Sergey Ulanov wrote:
> This parameter can fit on the previous line. clang-format please.

Done.

https://codereview.chromium.org/1867213002/diff/1/remoting/host/audio_capture...
remoting/host/audio_capturer_win.cc:259: // So we need to manually append volume
signal to the samples.
On 2016/04/11 17:58:01, Sergey Ulanov wrote:
> s/append volume signal/apply volume/

Done.

[Sergey Ulanov, 2016-04-11 22:00:31]

lgtm

[Hzj_jie, 2016-04-11 22:21:24]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2016-04-11 22:22:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867213002/20001

[commit-bot: I haz the power, 2016-04-11 22:30:04]

Description was changed from

==========
Support audio in curtain mode, and use endpoint volume instead of session volume
to adjust audio stream


BUG=597320,242312
==========

to

==========
Support audio in curtain mode, and use endpoint volume instead of session volume
to adjust audio stream


BUG=597320,242312
==========

[commit-bot: I haz the power, 2016-04-11 22:30:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-11 22:31:33]

Description was changed from

==========
Support audio in curtain mode, and use endpoint volume instead of session volume
to adjust audio stream


BUG=597320,242312
==========

to

==========
Support audio in curtain mode, and use endpoint volume instead of session volume
to adjust audio stream

BUG=597320,242312

Committed: https://crrev.com/fc96e4f848fb4cca37e2da244dc873c1831d70c5
Cr-Commit-Position: refs/heads/master@{#386497}
==========

[commit-bot: I haz the power, 2016-04-11 22:31:34]

Patchset 2 (id:??) landed as
https://crrev.com/fc96e4f848fb4cca37e2da244dc873c1831d70c5
Cr-Commit-Position: refs/heads/master@{#386497}