Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1867213002: Support audio in curtain mode, and use endpoint volume instead of session volume to adjust audio st… (Closed)

Created:
4 years, 8 months ago by Hzj_jie
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support audio in curtain mode, and use endpoint volume instead of session volume to adjust audio stream BUG=597320, 242312 Committed: https://crrev.com/fc96e4f848fb4cca37e2da244dc873c1831d70c5 Cr-Commit-Position: refs/heads/master@{#386497}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Resolve review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M remoting/host/audio_capturer_win.h View 3 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/audio_capturer_win.cc View 1 7 chunks +17 lines, -15 lines 0 comments Download
M remoting/host/win/rdp_client_window.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Hzj_jie
This change is to enable audio in curtain mode. As far as I can tell, ...
4 years, 8 months ago (2016-04-08 17:37:23 UTC) #2
Sergey Ulanov
Does audio play back properly with this change? We disabled audio under RDP because it ...
4 years, 8 months ago (2016-04-11 17:58:01 UTC) #3
Hzj_jie
I have tried this change on my machine with curtain mode on. And the audio ...
4 years, 8 months ago (2016-04-11 21:37:23 UTC) #5
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-04-11 22:00:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867213002/20001
4 years, 8 months ago (2016-04-11 22:22:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 22:30:05 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 22:31:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc96e4f848fb4cca37e2da244dc873c1831d70c5
Cr-Commit-Position: refs/heads/master@{#386497}

Powered by Google App Engine
This is Rietveld 408576698