Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1867153002: content: Add out-of-line copy ctors for complex classes. (Closed)

Created:
4 years, 8 months ago by vmpstr
Modified:
4 years, 8 months ago
Reviewers:
Nico, no sievers, dcheng
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mlamouri+watch-notifications_chromium.org, Peter Beverloo, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Add out-of-line copy ctors for complex classes. This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=sievers@chromium.org, dcheng@chromium.org, thakis@chromium.org Committed: https://crrev.com/2f1a96e280c8711f17a48ba9492110733ff78e33 Cr-Commit-Position: refs/heads/master@{#386163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M content/common/android/address_parser_internal.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/android/address_parser_internal.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/rendering_helper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/text_input_state.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/text_input_state.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/speech_recognition_session_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/speech_recognition_session_config.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/platform_notification_data.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/platform_notification_data.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vmpstr
Please take a look.
4 years, 8 months ago (2016-04-07 22:31:06 UTC) #1
dcheng
lgtm
4 years, 8 months ago (2016-04-07 22:33:11 UTC) #2
no sievers
lgtm
4 years, 8 months ago (2016-04-08 18:14:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867153002/1
4 years, 8 months ago (2016-04-08 18:26:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 19:50:38 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 19:53:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f1a96e280c8711f17a48ba9492110733ff78e33
Cr-Commit-Position: refs/heads/master@{#386163}

Powered by Google App Engine
This is Rietveld 408576698