LayoutTests/fast/notifications/notifications-constructor-with-permission.html - Issue 186713002: Add new layout tests for the Web Notification API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/notifications/notifications-constructor-with-permission.html

Issue 186713002: Add new layout tests for the Web Notification API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update existing tests Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/notifications/notification-replace.html ('K') | « LayoutTests/fast/notifications/notification-sandbox-permission-expected.txt ('k') | LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/notifications/notifications-constructor-with-permission.html

diff --git a/LayoutTests/fast/notifications/notifications-constructor-with-permission.html b/LayoutTests/fast/notifications/notifications-constructor-with-permission.html

index 717d7fec0c7e701db84afa74a19c85429e0cdad1..c4a820277cd77517ba86bf7be3ef2f152c9dfcc2 100644

--- a/LayoutTests/fast/notifications/notifications-constructor-with-permission.html

+++ b/LayoutTests/fast/notifications/notifications-constructor-with-permission.html

@@ -10,7 +10,7 @@

function runTests()

{

if (window.testRunner) {

- testRunner.grantWebNotificationPermission("file://");

+ testRunner.grantWebNotificationPermission("file://", true);

abarth-chromium 2014/03/04 19:07:35 What does |true| mean here? Can we use a string o

Peter Beverloo 2014/03/04 19:49:51 Do you think grantWebNotificationPermission(boolea

testRunner.dumpAsText();

testRunner.waitUntilDone();

}