MD Settings: Certificate manager, respect export/edit/delete restrictions.

chrome/test/data/webui/settings/certificate_manager_page_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('certificate_manager_page', function() {
   /**
    * A test version of CertificatesBrowserProxy. Provides helper methods
    * for allowing tests to know when a method was called, as well as
    * specifying mock responses.
    *
@@ skipping 512 matching lines @@
         MockInteractions.tap(viewButton);
         return browserProxy.whenCalled('viewCertificate').then(function(id) {
           assertEquals(subentry.model.id, id);
         });
       });
 
       // Test that the 'Edit' option is only shown when appropriate and that
       // once tapped the correct event is fired.
       test('MenuOptions_Edit', function() {
         var editButton = subentry.shadowRoot.querySelector('#edit');
+        assertTrue(!!editButton);
         // Should be disabled for any certificate type other than
         // CertificateType.CA
         assertTrue(editButton.hidden);
         subentry.certificateType = settings.CertificateType.CA;
         assertFalse(editButton.hidden);
 
+        // Should be disabled if |policy| is true.
+        var model = createSampleCertificateSubnode();
+        model.policy = true;
+        subentry.model = model;
+        assertTrue(editButton.hidden);
+
+        subentry.model = createSampleCertificateSubnode();
         var waitForActionEvent = actionEventToPromise();
         MockInteractions.tap(editButton);
         return waitForActionEvent.then(function(event) {
           var detail = /** @type {!CertificateActionEventDetail} */ (
               event.detail);
           assertEquals(settings.CertificateAction.EDIT, detail.action);
           assertEquals(subentry.model.id, detail.subnode.id);
           assertEquals(subentry.certificateType, detail.certificateType);
         });
       });
 
       // Test that the 'Delete' option is only shown when appropriate and that
       // once tapped the correct event is fired.
       test('MenuOptions_Delete', function() {
-        subentry.set('model.readonly', true);
+        var deleteButton = subentry.shadowRoot.querySelector('#delete');
+        assertTrue(!!deleteButton);
 
-        var deleteButton = subentry.shadowRoot.querySelector('#delete');
         // Should be disabled when 'model.readonly' is true.
+        var model = createSampleCertificateSubnode();
+        model.readonly = true;
+        subentry.model = model;
         assertTrue(deleteButton.hidden);
-        subentry.set('model.readonly', false);
-        assertFalse(deleteButton.hidden);
 
+        // Should be disabled when 'model.policy' is true.
+        var model = createSampleCertificateSubnode();
+        model.policy = true;
+        subentry.model = model;
+        assertTrue(deleteButton.hidden);
+
+        subentry.model = createSampleCertificateSubnode();
         var waitForActionEvent = actionEventToPromise();
         MockInteractions.tap(deleteButton);
         return waitForActionEvent.then(function(event) {
           var detail = /** @type {!CertificateActionEventDetail} */ (
               event.detail);
           assertEquals(settings.CertificateAction.DELETE, detail.action);
           assertEquals(subentry.model.id, detail.subnode.id);
         });
       });
 
-      // Test case of exporting a certificate that is not PERSONAL.
+      // Test that the 'Export' option is always shown when the certificate type
+      // is not PERSONAL and that once tapped the correct event is fired.
       test('MenuOptions_Export', function() {
         subentry.certificateType = settings.CertificateType.SERVER;
         var exportButton = subentry.shadowRoot.querySelector('#export');
+        assertTrue(!!exportButton);

[tommycli, 2016/04/07 21:35:01]

This assertion should be that it's not hidden right?

[dpapad, 2016/04/07 22:07:23]

Done (added both).

         MockInteractions.tap(exportButton);
         return browserProxy.whenCalled('exportCertificate').then(function(id) {
           assertEquals(subentry.model.id, id);
         });
       });
 
       // Test case of exporting a PERSONAL certificate.
       test('MenuOptions_ExportPersonal', function() {
+        var exportButton = subentry.shadowRoot.querySelector('#export');
+        assertTrue(!!exportButton);
+
+        // Should be disabled when 'model.extractable' is false.
+        assertTrue(exportButton.hidden);
+
+        var model = createSampleCertificateSubnode();
+        model.extractable = true;
+        subentry.model = model;
+        assertFalse(exportButton.hidden);
+
         var waitForActionEvent = actionEventToPromise();
-
-        var exportButton = subentry.shadowRoot.querySelector('#export');
         MockInteractions.tap(exportButton);
         return browserProxy.whenCalled('exportPersonalCertificate').then(
             function(id) {
               assertEquals(subentry.model.id, id);
 
               // A promise firing once |settings.CertificateActionEvent| is
               // fired.
               return waitForActionEvent;
             }).then(
             function(event) {
@@ skipping 224 matching lines @@
       registerCaTrustEditDialogTests();
       registerDeleteDialogTests();
       registerPasswordEncryptDialogTests();
       registerPasswordDecryptDialogTests();
       registerPageTests();
       registerCertificateSubentryTests();
       registerCertificateListTests();
     },
   };
 });