Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 1867093003: MD Settings: Certificate manager, respect export/edit/delete restrictions. (Closed)

Created:
4 years, 8 months ago by dpapad
Modified:
4 years, 8 months ago
Reviewers:
tommycli
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Certificate manager, respect export/edit restrictions. BUG=601543 Committed: https://crrev.com/35862172004f5cf57bb04902c2172b5dfd00686e Cr-Commit-Position: refs/heads/master@{#386135}

Patch Set 1 : Nit #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -14 lines) Patch
M chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js View 1 1 chunk +26 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificates_browser_proxy.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/certificate_manager_page_test.js View 1 4 chunks +35 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
dpapad
4 years, 8 months ago (2016-04-07 21:26:38 UTC) #5
tommycli
lgtm except below comments: https://codereview.chromium.org/1867093003/diff/60001/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js File chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js (right): https://codereview.chromium.org/1867093003/diff/60001/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js#newcode147 chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js:147: canEdit_: function() { Can these ...
4 years, 8 months ago (2016-04-07 21:35:01 UTC) #6
dpapad
https://codereview.chromium.org/1867093003/diff/60001/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js File chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js (right): https://codereview.chromium.org/1867093003/diff/60001/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js#newcode147 chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js:147: canEdit_: function() { On 2016/04/07 at 21:35:01, tommycli wrote: ...
4 years, 8 months ago (2016-04-07 22:07:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867093003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867093003/80001
4 years, 8 months ago (2016-04-07 22:08:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/207696)
4 years, 8 months ago (2016-04-08 00:03:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867093003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867093003/80001
4 years, 8 months ago (2016-04-08 17:16:26 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 8 months ago (2016-04-08 18:40:41 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 18:43:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35862172004f5cf57bb04902c2172b5dfd00686e
Cr-Commit-Position: refs/heads/master@{#386135}

Powered by Google App Engine
This is Rietveld 408576698