MD Settings: Certificate manager, respect export/edit/delete restrictions.

MD Settings: Certificate manager, respect export/edit restrictions.

BUG=601543
Committed: https://crrev.com/35862172004f5cf57bb04902c2172b5dfd00686e
Cr-Commit-Position: refs/heads/master@{#386135}

[dpapad, 2016-04-07 21:17:42]

Patchset #3 (id:40001) has been deleted

[dpapad, 2016-04-07 21:17:47]

Patchset #2 (id:20001) has been deleted

[dpapad, 2016-04-07 21:17:52]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-04-07 21:26:37]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2016-04-07 21:35:01]

lgtm except below comments:

https://codereview.chromium.org/1867093003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js
(right):

https://codereview.chromium.org/1867093003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js:147:
canEdit_: function() {
Can these be pure functions a la the style guide Polymer #3?
https://docs.google.com/document/d/1G0t519y_cSW4etXVwruR145abZH0N5-9R7JyejzVo...

https://codereview.chromium.org/1867093003/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/certificate_manager_page_test.js (right):

https://codereview.chromium.org/1867093003/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/certificate_manager_page_test.js:592:
assertTrue(!!exportButton);
This assertion should be that it's not hidden right?

[dpapad, 2016-04-07 22:07:23]

https://codereview.chromium.org/1867093003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js
(right):

https://codereview.chromium.org/1867093003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js:147:
canEdit_: function() {
On 2016/04/07 at 21:35:01, tommycli wrote:
> Can these be pure functions a la the style guide Polymer #3?
https://docs.google.com/document/d/1G0t519y_cSW4etXVwruR145abZH0N5-9R7JyejzVo...

Done.

https://codereview.chromium.org/1867093003/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/certificate_manager_page_test.js (right):

https://codereview.chromium.org/1867093003/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/certificate_manager_page_test.js:592:
assertTrue(!!exportButton);
On 2016/04/07 at 21:35:01, tommycli wrote:
> This assertion should be that it's not hidden right?

Done (added both).

[dpapad, 2016-04-07 22:08:01]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-04-07 22:08:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/1867093003/#ps80001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-04-07 22:08:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867093003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867093003/80001

[commit-bot: I haz the power, 2016-04-08 00:03:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 00:03:00]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2016-04-08 17:16:05]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-04-08 17:16:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867093003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867093003/80001

[commit-bot: I haz the power, 2016-04-08 18:40:41]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-04-08 18:43:08]

Description was changed from

==========
MD Settings: Certificate manager, respect export/edit restrictions.

BUG=601543
==========

to

==========
MD Settings: Certificate manager, respect export/edit restrictions.

BUG=601543

Committed: https://crrev.com/35862172004f5cf57bb04902c2172b5dfd00686e
Cr-Commit-Position: refs/heads/master@{#386135}
==========

[commit-bot: I haz the power, 2016-04-08 18:43:09]

Patchset 2 (id:??) landed as
https://crrev.com/35862172004f5cf57bb04902c2172b5dfd00686e
Cr-Commit-Position: refs/heads/master@{#386135}