Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1867093002:
Add support for defaulting to low quality image interpolation. (Closed)
|
Created:
4 years, 8 months ago by nyquist Modified:
4 years, 8 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd support for defaulting to low quality image interpolation.
Currently only Android sets the flag for
WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION since it has been the only
platform needing it.
When painting images on one platform, and reproducing them
remotely, the painting side must make sure that the receiving side
is able to render them and ensure that there is no mismatch.
This CL declares a new GN arg so that other platforms may optionally
set this flag as well. The new GN arg is
use_low_quality_image_interpolation and it defaults to is_android.
There should be no changes to existing behavior if the flag is not
set.
BUG=597803
R=dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/384c6056c4e1d0eb347f705c454437ae40e6f7cb
Cr-Commit-Position: refs/heads/master@{#385913}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Make default value of use_low_quality_image_interpolation = is_android #
Messages
Total messages: 22 (12 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by nyquist@chromium.org to run a CQ dry run
Description was changed from ========== Add support for defaulting to low quality image interpolation. Currently only Android sets the flag for WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION since it has been the only platform needing it. When painting images on one platform, and reproducing them remotely, the painting side must make sure that the receiving side is able to render them and ensure that there is no mismatch. This CL declares a new GN arg so that other platforms may optionally set this flag as well. The new GN arg is use_low_quality_image_interpolation and it defaults to false. There should be no changes to existing behavior if the flag is not set. BUG=597803 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Add support for defaulting to low quality image interpolation. Currently only Android sets the flag for WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION since it has been the only platform needing it. When painting images on one platform, and reproducing them remotely, the painting side must make sure that the receiving side is able to render them and ensure that there is no mismatch. This CL declares a new GN arg so that other platforms may optionally set this flag as well. The new GN arg is use_low_quality_image_interpolation and it defaults to false. There should be no changes to existing behavior if the flag is not set. BUG=597803 R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
nyquist@chromium.org changed reviewers: + dpranke@chromium.org
dpranke: PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867093002/20001
lgtm. The suggestion below is optional. https://codereview.chromium.org/1867093002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/config.gni (right): https://codereview.chromium.org/1867093002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/config.gni:33: use_low_quality_image_interpolation = false Does it make sense to default this to "= is_android" ?
https://codereview.chromium.org/1867093002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/config.gni (right): https://codereview.chromium.org/1867093002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/config.gni:33: use_low_quality_image_interpolation = false On 2016/04/07 19:46:23, Dirk Pranke wrote: > Does it make sense to default this to "= is_android" ? That makes total sense to me. I'm assuming you also want to remove "is_android" below as well then.
yup. lgtm.
The CQ bit was checked by nyquist@chromium.org
The CQ bit was unchecked by nyquist@chromium.org
Description was changed from ========== Add support for defaulting to low quality image interpolation. Currently only Android sets the flag for WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION since it has been the only platform needing it. When painting images on one platform, and reproducing them remotely, the painting side must make sure that the receiving side is able to render them and ensure that there is no mismatch. This CL declares a new GN arg so that other platforms may optionally set this flag as well. The new GN arg is use_low_quality_image_interpolation and it defaults to false. There should be no changes to existing behavior if the flag is not set. BUG=597803 R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Add support for defaulting to low quality image interpolation. Currently only Android sets the flag for WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION since it has been the only platform needing it. When painting images on one platform, and reproducing them remotely, the painting side must make sure that the receiving side is able to render them and ensure that there is no mismatch. This CL declares a new GN arg so that other platforms may optionally set this flag as well. The new GN arg is use_low_quality_image_interpolation and it defaults to is_android. There should be no changes to existing behavior if the flag is not set. BUG=597803 R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
The CQ bit was checked by nyquist@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867093002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nyquist@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867093002/40001
Message was sent while issue was closed.
Description was changed from ========== Add support for defaulting to low quality image interpolation. Currently only Android sets the flag for WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION since it has been the only platform needing it. When painting images on one platform, and reproducing them remotely, the painting side must make sure that the receiving side is able to render them and ensure that there is no mismatch. This CL declares a new GN arg so that other platforms may optionally set this flag as well. The new GN arg is use_low_quality_image_interpolation and it defaults to is_android. There should be no changes to existing behavior if the flag is not set. BUG=597803 R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Add support for defaulting to low quality image interpolation. Currently only Android sets the flag for WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION since it has been the only platform needing it. When painting images on one platform, and reproducing them remotely, the painting side must make sure that the receiving side is able to render them and ensure that there is no mismatch. This CL declares a new GN arg so that other platforms may optionally set this flag as well. The new GN arg is use_low_quality_image_interpolation and it defaults to is_android. There should be no changes to existing behavior if the flag is not set. BUG=597803 R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add support for defaulting to low quality image interpolation. Currently only Android sets the flag for WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION since it has been the only platform needing it. When painting images on one platform, and reproducing them remotely, the painting side must make sure that the receiving side is able to render them and ensure that there is no mismatch. This CL declares a new GN arg so that other platforms may optionally set this flag as well. The new GN arg is use_low_quality_image_interpolation and it defaults to is_android. There should be no changes to existing behavior if the flag is not set. BUG=597803 R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Add support for defaulting to low quality image interpolation. Currently only Android sets the flag for WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION since it has been the only platform needing it. When painting images on one platform, and reproducing them remotely, the painting side must make sure that the receiving side is able to render them and ensure that there is no mismatch. This CL declares a new GN arg so that other platforms may optionally set this flag as well. The new GN arg is use_low_quality_image_interpolation and it defaults to is_android. There should be no changes to existing behavior if the flag is not set. BUG=597803 R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/384c6056c4e1d0eb347f705c454437ae40e6f7cb Cr-Commit-Position: refs/heads/master@{#385913} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/384c6056c4e1d0eb347f705c454437ae40e6f7cb Cr-Commit-Position: refs/heads/master@{#385913} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
