Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: pkg/analysis_server/test/domain_completion_test.dart

Issue 1867063003: show only named argument suggestions - fixes #25198, fixes #23992 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/domain_completion_test.dart
diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart
index 045d8d325ea2c427fbf218fccb16ca63e1a4f40f..ec7c5205e4ec0d4d8dfd159b3c4ee6f155575d4b 100644
--- a/pkg/analysis_server/test/domain_completion_test.dart
+++ b/pkg/analysis_server/test/domain_completion_test.dart
@@ -28,6 +28,55 @@ main() {
@reflectiveTest
class CompletionDomainHandlerTest extends AbstractCompletionDomainTest {
+ test_ArgumentList_imported_function_named_param() async {
+ addTestFile('main() { int.parse("16", ^);}');
+ await getSuggestions();
+ assertHasResult(CompletionSuggestionKind.NAMED_ARGUMENT, 'radix: ',
+ relevance: DART_RELEVANCE_NAMED_PARAMETER);
+ assertHasResult(CompletionSuggestionKind.NAMED_ARGUMENT, 'onError: ',
+ relevance: DART_RELEVANCE_NAMED_PARAMETER);
+ expect(suggestions, hasLength(2));
+ }
+
+ test_ArgumentList_imported_function_named_param1() async {
+ addTestFile('main() { foo(o^);} foo({one, two}) {}');
+ await getSuggestions();
+ assertHasResult(CompletionSuggestionKind.NAMED_ARGUMENT, 'one: ',
+ relevance: DART_RELEVANCE_NAMED_PARAMETER);
+ assertHasResult(CompletionSuggestionKind.NAMED_ARGUMENT, 'two: ',
+ relevance: DART_RELEVANCE_NAMED_PARAMETER);
+ expect(suggestions, hasLength(2));
+ }
+
+ test_ArgumentList_imported_function_named_param_label1() async {
+ addTestFile('main() { int.parse("16", r^: 16);}');
+ await getSuggestions();
+ assertHasResult(CompletionSuggestionKind.NAMED_ARGUMENT, 'radix: ',
+ relevance: DART_RELEVANCE_NAMED_PARAMETER);
+ assertHasResult(CompletionSuggestionKind.NAMED_ARGUMENT, 'onError: ',
+ relevance: DART_RELEVANCE_NAMED_PARAMETER);
+ expect(suggestions, hasLength(2));
+ }
+
+ test_ArgumentList_imported_function_named_param_label3() async {
+ addTestFile('main() { int.parse("16", ^: 16);}');
+ await getSuggestions();
+ assertHasResult(CompletionSuggestionKind.NAMED_ARGUMENT, 'radix: ',
+ relevance: DART_RELEVANCE_NAMED_PARAMETER);
+ assertHasResult(CompletionSuggestionKind.NAMED_ARGUMENT, 'onError: ',
+ relevance: DART_RELEVANCE_NAMED_PARAMETER);
+ expect(suggestions, hasLength(2));
+ }
+
+ test_ArgumentList_imported_function_named_param2() async {
+ addTestFile('mainx() {A a = new A(); a.foo(one: 7, ^);}'
+ 'class A { foo({one, two}) {} }');
+ await getSuggestions();
+ assertHasResult(CompletionSuggestionKind.NAMED_ARGUMENT, 'two: ',
+ relevance: DART_RELEVANCE_NAMED_PARAMETER);
+ expect(suggestions, hasLength(1));
+ }
+
test_html() {
testFile = '/project/web/test.html';
addTestFile('''

Powered by Google App Engine
This is Rietveld 408576698