Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1867063003: show only named argument suggestions - fixes #25198, fixes #23992 (Closed)

Created:
4 years, 8 months ago by danrubel
Modified:
4 years, 8 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

show only named argument suggestions - fixes #25198, fixes #23992 R=jwren@google.com Committed: https://github.com/dart-lang/sdk/commit/dbaf0c33b0a563868043b5a1eefe8666cda78f6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 4 chunks +43 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/optype_test.dart View 3 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years, 8 months ago (2016-04-07 22:56:24 UTC) #2
jwren
On 2016/04/07 22:56:24, danrubel wrote: LGTM
4 years, 8 months ago (2016-04-08 16:44:10 UTC) #3
danrubel
4 years, 8 months ago (2016-04-08 16:54:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dbaf0c33b0a563868043b5a1eefe8666cda78f6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698