Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1867053005: Improve HTMLMediaElement media track status logging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index b63151e8f15d21d1043e9d9441db746f36f33a3f..c1aa3540b8c01a3399f66f53b736dc17cb4aabb0 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -2331,9 +2331,9 @@ AudioTrackList& HTMLMediaElement::audioTracks()
return *m_audioTracks;
}
-void HTMLMediaElement::audioTrackChanged()
+void HTMLMediaElement::audioTrackChanged(WebMediaPlayer::TrackId trackId, bool enabled)
{
- WTF_LOG(Media, "HTMLMediaElement::audioTrackChanged(%p)", this);
+ WTF_LOG(Media, "HTMLMediaElement::audioTrackChanged(%p) trackId=%u enabled=%d", this, trackId, enabled ? 1 : 0);
philipj_slow 2016/04/08 09:28:15 Just enabled without ternary expression does the s
servolk 2016/04/08 16:56:13 Done.
ASSERT(RuntimeEnabledFeatures::audioVideoTracksEnabled());
audioTracks().scheduleChangeEvent();
@@ -2389,7 +2389,7 @@ VideoTrackList& HTMLMediaElement::videoTracks()
void HTMLMediaElement::selectedVideoTrackChanged(WebMediaPlayer::TrackId* selectedTrackId)
{
- WTF_LOG(Media, "HTMLMediaElement::selectedVideoTrackChanged(%p)", this);
+ WTF_LOG(Media, "HTMLMediaElement::selectedVideoTrackChanged(%p) selectedTrackId=%s", this, (selectedTrackId ? String::format("%u", *selectedTrackId).ascii().data() : "none"));
philipj_slow 2016/04/08 09:28:15 Don't need the parenthesis around the last argumen
servolk 2016/04/08 16:56:13 Done.
ASSERT(RuntimeEnabledFeatures::audioVideoTracksEnabled());
if (selectedTrackId)
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | third_party/WebKit/Source/core/html/track/AudioTrack.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698