Improve HTMLMediaElement media track status logging

Improve HTMLMediaElement media track status logging

BUG=249427
Committed: https://crrev.com/e8e411f068ec81d03726f7f4efbab69c0802d54b
Cr-Commit-Position: refs/heads/master@{#386134}

[servolk, 2016-04-07 21:51:17]

servolk@chromium.org changed reviewers:
+ philipj@opera.com

[philipj_slow, 2016-04-08 09:28:15]

lgtm

https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2336: WTF_LOG(Media,
"HTMLMediaElement::audioTrackChanged(%p) trackId=%u enabled=%d", this, trackId,
enabled ? 1 : 0);
Just enabled without ternary expression does the same thing, see
HTMLMediaElement::addAudioTrack

https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2392: WTF_LOG(Media,
"HTMLMediaElement::selectedVideoTrackChanged(%p) selectedTrackId=%s", this,
(selectedTrackId ? String::format("%u", *selectedTrackId).ascii().data() :
"none"));
Don't need the parenthesis around the last argument.

[servolk, 2016-04-08 16:56:13]

https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2336: WTF_LOG(Media,
"HTMLMediaElement::audioTrackChanged(%p) trackId=%u enabled=%d", this, trackId,
enabled ? 1 : 0);
On 2016/04/08 09:28:15, philipj wrote:
> Just enabled without ternary expression does the same thing, see
> HTMLMediaElement::addAudioTrack

Done.

https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2392: WTF_LOG(Media,
"HTMLMediaElement::selectedVideoTrackChanged(%p) selectedTrackId=%s", this,
(selectedTrackId ? String::format("%u", *selectedTrackId).ascii().data() :
"none"));
On 2016/04/08 09:28:15, philipj wrote:
> Don't need the parenthesis around the last argument.

Done.

[servolk, 2016-04-08 16:56:21]

The CQ bit was checked by servolk@chromium.org

[servolk, 2016-04-08 16:56:22]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1867053005/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-04-08 16:56:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867053005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867053005/20001

[servolk, 2016-04-08 18:29:19]

Description was changed from

==========
Improve HTMLMediaElement media track status logging
==========

to

==========
Improve HTMLMediaElement media track status logging

BUG=249427
==========

[commit-bot: I haz the power, 2016-04-08 18:39:39]

Description was changed from

==========
Improve HTMLMediaElement media track status logging

BUG=249427
==========

to

==========
Improve HTMLMediaElement media track status logging

BUG=249427
==========

[commit-bot: I haz the power, 2016-04-08 18:39:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-08 18:41:08]

Description was changed from

==========
Improve HTMLMediaElement media track status logging

BUG=249427
==========

to

==========
Improve HTMLMediaElement media track status logging

BUG=249427

Committed: https://crrev.com/e8e411f068ec81d03726f7f4efbab69c0802d54b
Cr-Commit-Position: refs/heads/master@{#386134}
==========

[commit-bot: I haz the power, 2016-04-08 18:41:09]

Patchset 2 (id:??) landed as
https://crrev.com/e8e411f068ec81d03726f7f4efbab69c0802d54b
Cr-Commit-Position: refs/heads/master@{#386134}