Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1867053005: Improve HTMLMediaElement media track status logging (Closed)

Created:
4 years, 8 months ago by servolk
Modified:
4 years, 8 months ago
Reviewers:
philipj_slow
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve HTMLMediaElement media track status logging BUG=249427 Committed: https://crrev.com/e8e411f068ec81d03726f7f4efbab69c0802d54b Cr-Commit-Position: refs/heads/master@{#386134}

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/AudioTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
servolk
4 years, 8 months ago (2016-04-07 21:51:28 UTC) #2
philipj_slow
lgtm https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode2336 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2336: WTF_LOG(Media, "HTMLMediaElement::audioTrackChanged(%p) trackId=%u enabled=%d", this, trackId, enabled ? ...
4 years, 8 months ago (2016-04-08 09:28:15 UTC) #3
servolk
https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1867053005/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode2336 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2336: WTF_LOG(Media, "HTMLMediaElement::audioTrackChanged(%p) trackId=%u enabled=%d", this, trackId, enabled ? 1 ...
4 years, 8 months ago (2016-04-08 16:56:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867053005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867053005/20001
4 years, 8 months ago (2016-04-08 16:56:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 18:39:40 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 18:41:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8e411f068ec81d03726f7f4efbab69c0802d54b
Cr-Commit-Position: refs/heads/master@{#386134}

Powered by Google App Engine
This is Rietveld 408576698