src/pathops/SkPathOpsSimplify.cpp - Issue 1867053002: Appease valgrind wrt testing code initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkPathOpsSimplify.cpp

Issue 1867053002: Appease valgrind wrt testing code initialization (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address code review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkPathOpsSimplify.cpp

diff --git a/src/pathops/SkPathOpsSimplify.cpp b/src/pathops/SkPathOpsSimplify.cpp

index 08bb26d9a91255f55768605e6ff0cdadaaad0093..97f0350db2574e1ecd058a43805c6a40e6b23e19 100644

--- a/src/pathops/SkPathOpsSimplify.cpp

+++ b/src/pathops/SkPathOpsSimplify.cpp

@@ -216,7 +216,7 @@ bool Simplify(const SkPath& path, SkPath* result) {

result->reset();

result->setFillType(fillType);

SkPathWriter wrapper(*result);

- bool closable;

+ bool closable SK_INIT_TO_AVOID_WARNING;

if (builder.xorMask() == kWinding_PathOpsMask

? !bridgeWinding(contourList, &wrapper, &allocator, &closable)

: !bridgeXor(contourList, &wrapper, &allocator, &closable)) {

« no previous file with comments | « include/gpu/GrTestUtils.h ('k') | tests/PathOpsSimplifyRectThreadedTest.cpp » ('j') | no next file with comments »