Appease valgrind wrt testing code initialization

Appease valgrind wrt testing code initialization

The new swarming valgrind bot appears to be higher maintenance. These changes seem harmless and will, hopefully, unblock the bot.

TBR=bsalomon@google.com

https://build.chromium.org/p/client.skia.fyi/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-SwarmingValgrind/builds/57

BUG=skia:5164
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1867053002

Committed: https://skia.googlesource.com/skia/+/73add93a9cac83f2369dec94e3e392d26590c838

[robertphillips, 2016-04-07 14:59:43]

Description was changed from

==========
Appease valgrind wrt testing code initialization

BUG=skia:5164
==========

to

==========
Appease valgrind wrt testing code initialization

BUG=skia:5164
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-07 15:01:15]

Description was changed from

==========
Appease valgrind wrt testing code initialization

BUG=skia:5164
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Appease valgrind wrt testing code initialization

The new swarming valgrind bot appears to be higher maintenance. These changes
seem harmless and will, hopefully, unblock the bot.

BUG=skia:5164
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-07 15:01:15]

robertphillips@google.com changed reviewers:
+ caryclark@google.com, jvanverth@google.com

[robertphillips, 2016-04-07 15:01:58]

Description was changed from

==========
Appease valgrind wrt testing code initialization

The new swarming valgrind bot appears to be higher maintenance. These changes
seem harmless and will, hopefully, unblock the bot.

BUG=skia:5164
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Appease valgrind wrt testing code initialization

The new swarming valgrind bot appears to be higher maintenance. These changes
seem harmless and will, hopefully, unblock the bot.

https://build.chromium.org/p/client.skia.fyi/builders/Test-Ubuntu-GCC-Shuttle...

BUG=skia:5164
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[caryclark, 2016-04-07 15:10:47]

lgtm 

Is SK_INIT_TO_AVOID_WARNING

appropriate here?

[robertphillips, 2016-04-07 15:15:03]

It is indeed - Done. (Didn't know about that option.)

[robertphillips, 2016-04-07 15:15:41]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 15:15:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867053002/40001

[commit-bot: I haz the power, 2016-04-07 15:28:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 15:28:20]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-07 15:54:47]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-07 15:54:47]

The patchset sent to the CQ was uploaded after l-g-t-m from caryclark@google.com
Link to the patchset: https://codereview.chromium.org/1867053002/#ps40001
(title: "Address code review comments")

[commit-bot: I haz the power, 2016-04-07 15:54:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867053002/40001

[commit-bot: I haz the power, 2016-04-07 15:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 15:56:24]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2016-04-07 16:00:20]

Description was changed from

==========
Appease valgrind wrt testing code initialization

The new swarming valgrind bot appears to be higher maintenance. These changes
seem harmless and will, hopefully, unblock the bot.

https://build.chromium.org/p/client.skia.fyi/builders/Test-Ubuntu-GCC-Shuttle...

BUG=skia:5164
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Appease valgrind wrt testing code initialization

The new swarming valgrind bot appears to be higher maintenance. These changes
seem harmless and will, hopefully, unblock the bot.

TBR=bsalomon@google.com

https://build.chromium.org/p/client.skia.fyi/builders/Test-Ubuntu-GCC-Shuttle...

BUG=skia:5164
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-07 16:00:20]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-04-07 16:00:26]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-04-07 16:00:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867053002/40001

[commit-bot: I haz the power, 2016-04-07 16:01:23]

Description was changed from

==========
Appease valgrind wrt testing code initialization

The new swarming valgrind bot appears to be higher maintenance. These changes
seem harmless and will, hopefully, unblock the bot.

TBR=bsalomon@google.com

https://build.chromium.org/p/client.skia.fyi/builders/Test-Ubuntu-GCC-Shuttle...

BUG=skia:5164
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Appease valgrind wrt testing code initialization

The new swarming valgrind bot appears to be higher maintenance. These changes
seem harmless and will, hopefully, unblock the bot.

TBR=bsalomon@google.com

https://build.chromium.org/p/client.skia.fyi/builders/Test-Ubuntu-GCC-Shuttle...

BUG=skia:5164
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/73add93a9cac83f2369dec94e3e392d26590c838
==========

[commit-bot: I haz the power, 2016-04-07 16:01:24]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/73add93a9cac83f2369dec94e3e392d26590c838