Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1867003005: Add test expectations for recent regressions caught by Site Isolation FYI bot. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
Reviewers:
alexmos
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test expectations for recent regressions caught by Site Isolation FYI bot. BUG=601584, 601581 NOTRY=true Committed: https://crrev.com/315cc7123ae79a389900c4c28856577fd042709a Cr-Commit-Position: refs/heads/master@{#385904}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Comment formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Łukasz Anforowicz
Alex, could you please take a look? This covers 2 of the recent failures. This ...
4 years, 8 months ago (2016-04-07 22:10:32 UTC) #2
alexmos
LGTM, thanks for triaging these! https://codereview.chromium.org/1867003005/diff/20001/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right): https://codereview.chromium.org/1867003005/diff/20001/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process#newcode84 third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:84: # cross-origin-iframe.html layout test ...
4 years, 8 months ago (2016-04-07 22:21:17 UTC) #3
Łukasz Anforowicz
Thanks for reviewing. I've added NOTRY=true and will push to CQ in a second. https://codereview.chromium.org/1867003005/diff/20001/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process ...
4 years, 8 months ago (2016-04-07 22:24:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867003005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867003005/40001
4 years, 8 months ago (2016-04-07 22:25:12 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-07 22:33:55 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 22:36:42 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/315cc7123ae79a389900c4c28856577fd042709a
Cr-Commit-Position: refs/heads/master@{#385904}

Powered by Google App Engine
This is Rietveld 408576698