sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart - Issue 18670003: Remove support for conflicting constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

Issue 18670003: Remove support for conflicting constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/mirrors/mirrors.dart ('k') | sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart b/sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

index a0bbe66cc60117b3471ac55972fe940d1bcac87a..182a83fc7cc6544766a36a6fb2a20f23e2c455fe 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

@@ -40,9 +40,6 @@ String displayName(DeclarationMirror mirror) {

} else if (methodMirror.isOperator) {

return 'operator ${operatorName(methodMirror)}';

} else if (methodMirror.isConstructor) {

- // TODO(johnniwinther): Remove this when [simpleName] is

- // [constructorName].

- simpleName = methodMirror.constructorName;

String className = displayName(methodMirror.owner);

if (simpleName == '') {

return className;