Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 18670003: Remove support for conflicting constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index e8abbb2a97ff4ae40ef4b5d1c29886b1c66cf337..65e1d4639046bd8313920765611f3fc0d07d7e4c 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -1262,18 +1262,20 @@ class CodeEmitterTask extends CompilerTask {
int requiredParameterCount;
int optionalParameterCount;
String namedArguments = '';
- bool isConstructor;
+ bool isConstructor = false;
if (elementOrSelector is Selector) {
Selector selector = elementOrSelector;
requiredParameterCount = selector.argumentCount;
optionalParameterCount = 0;
- isConstructor = false;
namedArguments = namedParametersAsReflectionNames(selector);
} else {
FunctionElement function = elementOrSelector;
+ if (function.isConstructor()) {
+ isConstructor = true;
+ name = Elements.reconstructConstructorName(function);
ahe 2013/07/11 10:09:42 Add a TODO for me to get rid of this.
Johnni Winther 2013/07/11 13:09:19 Done.
+ }
requiredParameterCount = function.requiredParameterCount(compiler);
optionalParameterCount = function.optionalParameterCount(compiler);
- isConstructor = function.isConstructor();
FunctionSignature signature = function.computeSignature(compiler);
if (signature.optionalParametersAreNamed) {
var names = [];

Powered by Google App Engine
This is Rietveld 408576698