Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

Issue 18670003: Remove support for conflicting constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
index ddc8571318ae419838a04fc1f52576684ad10a42..6dc9ad873e019493f9c62a3cfd808c0c340f0ee0 100644
--- a/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
@@ -109,20 +109,13 @@ void renamePlaceholders(
assert(element.isConstructor());
StringBuffer result = new StringBuffer();
String name = element.name.slowToString();
- if (element.name != element.getEnclosingClass().name) {
+ if (element.name != const SourceString('')) {
// Named constructor or factory. Is there a more reliable way to check
// this case?
if (!placeholder.isRedirectingCall) {
result.write(renameType(placeholder.type, renameElement));
result.write('.');
}
- String prefix = '${element.getEnclosingClass().name.slowToString()}\$';
- if (!name.startsWith(prefix)) {
- // Factory for another interface (that is going away soon).
- compiler.internalErrorOnElement(element,
- "Factory constructors for external interfaces are not supported.");
- }
- name = name.substring(prefix.length);
if (!element.getLibrary().isPlatformLibrary) {
name = renameString(element.getLibrary(), name);
}

Powered by Google App Engine
This is Rietveld 408576698