Remove support for conflicting constructors.

sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library mirrors_dart2js;
 
 import 'dart:async';
 import 'dart:collection' show LinkedHashMap;
 
 import '../../compiler.dart' as api;
@@ skipping 1254 matching lines @@
 }
 
 //------------------------------------------------------------------------------
 // Member mirrors implementation.
 //------------------------------------------------------------------------------
 
 class Dart2JsMethodMirror extends Dart2JsMemberMirror
     implements MethodMirror {
   final Dart2JsContainerMirror _objectMirror;
   final String simpleName;
-  final String constructorName;
   final Dart2JsMethodKind _kind;
 
   Dart2JsMethodMirror._internal(Dart2JsContainerMirror objectMirror,
       FunctionElement function,
       String this.simpleName,
-      String this.constructorName,
       Dart2JsMethodKind this._kind)
       : this._objectMirror = objectMirror,
         super(objectMirror.mirrors, function);
 
   factory Dart2JsMethodMirror(Dart2JsContainerMirror objectMirror,
                               FunctionElement function) {
     String realName = function.name.slowToString();
     // TODO(ahe): This method should not be calling
     // Elements.operatorNameToIdentifier.
     String simpleName =
         Elements.operatorNameToIdentifier(function.name).slowToString();
-    String constructorName = null;
     Dart2JsMethodKind kind;
     if (function.kind == ElementKind.GETTER) {
       kind = Dart2JsMethodKind.GETTER;
     } else if (function.kind == ElementKind.SETTER) {
       kind = Dart2JsMethodKind.SETTER;
       simpleName = '$simpleName=';
     } else if (function.kind == ElementKind.GENERATIVE_CONSTRUCTOR) {
       // TODO(johnniwinther): Support detection of redirecting constructors.
-      constructorName = '';
-      int dollarPos = simpleName.indexOf('\$');
-      if (dollarPos != -1) {
-        constructorName = simpleName.substring(dollarPos + 1);
-        simpleName = simpleName.substring(0, dollarPos);
-        // Simple name is TypeName.constructorName.
-        simpleName = '$simpleName.$constructorName';
-      } else {
-        // Simple name is TypeName.
-      }
       if (function.modifiers.isConst()) {
         kind = Dart2JsMethodKind.CONST;
       } else {
         kind = Dart2JsMethodKind.GENERATIVE;
       }
     } else if (function.modifiers.isFactory()) {
       kind = Dart2JsMethodKind.FACTORY;
-      constructorName = '';
-      int dollarPos = simpleName.indexOf('\$');
-      if (dollarPos != -1) {
-        constructorName = simpleName.substring(dollarPos+1);
-        simpleName = simpleName.substring(0, dollarPos);
-        simpleName = '$simpleName.$constructorName';
-      }
     } else if (realName == 'unary-') {
       kind = Dart2JsMethodKind.OPERATOR;
       // Simple name is 'unary-'.
       simpleName = Mirror.UNARY_MINUS;
     } else if (simpleName.startsWith('operator\$')) {
       String str = simpleName.substring(9);
       simpleName = 'operator';
       kind = Dart2JsMethodKind.OPERATOR;
       simpleName = _getOperatorFromOperatorName(str);
     } else {
       kind = Dart2JsMethodKind.REGULAR;
     }
     return new Dart2JsMethodMirror._internal(objectMirror, function,
-        simpleName, constructorName, kind);
+        simpleName, kind);
   }
 
   FunctionElement get _function => _element;
 
   String get qualifiedName
       => '${owner.qualifiedName}.$simpleName';
 
   DeclarationMirror get owner => _objectMirror;
 
   bool get isTopLevel => _objectMirror is LibraryMirror;
 
   bool get isConstructor
       => isGenerativeConstructor || isConstConstructor ||
          isFactoryConstructor || isRedirectingConstructor;
 
   bool get isMethod => !isConstructor;
 
-  bool get isPrivate =>
-      isConstructor ? _isPrivate(constructorName) : _isPrivate(simpleName);
-
   bool get isStatic => _function.modifiers.isStatic();
 
   List<ParameterMirror> get parameters {
     return _parametersFromFunctionSignature(mirrors, this,
         _function.computeSignature(mirrors.compiler));
   }
 
   TypeMirror get returnType => _convertTypeToTypeMirror(
       mirrors, _function.computeSignature(mirrors.compiler).returnType,
       mirrors.compiler.types.dynamicType);
@@ skipping 318 matching lines @@
  *
  * All API in this class is experimental.
  */
 class BackDoor {
   /// Return the compilation units comprising [library].
   static List<Mirror> compilationUnitsOf(Dart2JsLibraryMirror library) {
     return library._library.compilationUnits.toList().map(
         (cu) => new Dart2JsCompilationUnitMirror(cu, library)).toList();
   }
 }