Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1866953002: [test] Rework how default timeout is handled. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, john.yan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Rework how default timeout is handled. The slow_archs list had only an effect when no timeout was passed. Now it will also increase the timeout on the bots. Also simplified the code a bit. Committed: https://crrev.com/05047108375ddfcf407418a3fc9f3dcef90efd11 Cr-Commit-Position: refs/heads/master@{#35355}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M tools/run-tests.py View 1 3 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL. The old behavior has a not so obvious pitfall and CLs like this https://codereview.chromium.org/1869683002/ ...
4 years, 8 months ago (2016-04-07 10:15:41 UTC) #3
Jakob Kummerow
LGTM!
4 years, 8 months ago (2016-04-08 11:31:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866953002/20001
4 years, 8 months ago (2016-04-08 11:48:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 12:10:18 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 12:11:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05047108375ddfcf407418a3fc9f3dcef90efd11
Cr-Commit-Position: refs/heads/master@{#35355}

Powered by Google App Engine
This is Rietveld 408576698