Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1866933002: breakpad: fix GN build files for microdump_stackwalk (Closed)

Created:
4 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Mark Mentovai, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

breakpad: fix GN build files for microdump_stackwalk Some copy/paste error was causing breakpad executables like microdump_stackwalk to be symlinked against dump_syms, which is unrelated BUG=601355 TBR=mark@chromium.org Committed: https://crrev.com/4ecbb21114b83df4830c3d1dc7d4b8491b1b0383 Cr-Commit-Position: refs/heads/master@{#385738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M breakpad/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Primiano Tucci (use gerrit)
4 years, 8 months ago (2016-04-07 09:35:25 UTC) #2
agrieve
On 2016/04/07 09:35:25, Primiano Tucci wrote: lgtm. Whoops!
4 years, 8 months ago (2016-04-07 13:08:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866933002/1
4 years, 8 months ago (2016-04-07 13:22:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 13:27:32 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 13:28:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ecbb21114b83df4830c3d1dc7d4b8491b1b0383
Cr-Commit-Position: refs/heads/master@{#385738}

Powered by Google App Engine
This is Rietveld 408576698