DevTools: Prevent setting huge textContent in UI.

Source/devtools/front_end/ObjectPropertiesSection.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 186 matching lines @@
             this.nameElement.classList.add("properties-accessor-property-name");
 
         var separatorElement = document.createElement("span");
         separatorElement.className = "separator";
         separatorElement.textContent = ": ";
 
         if (this.property.value) {
             this.valueElement = document.createElement("span");
             this.valueElement.className = "value";
             var description = this.property.value.description;
-            // Render \n as a nice unicode cr symbol.
             if (this.property.wasThrown) {
-                this.valueElement.textContent = "[Exception: " + description + "]";
+                var text = "[Exception: " + description + "]";
+                this.valueElement.setTextContentTruncatedIfNeeded(text);

[pfeldman, 2014/03/05 05:14:03]

Do it once for all below?

[aandrey, 2014/03/05 10:47:35]

Done.

             } else if (this.property.value.type === "string" && typeof description === "string") {
-                this.valueElement.textContent = "\"" + description.replace(/\n/g, "\u21B5") + "\"";
+                // Render \n as a nice unicode cr symbol.
+                var text = "\"" + description.replace(/\n/g, "\u21B5") + "\"";
+                this.valueElement.setTextContentTruncatedIfNeeded(text);
                 this.valueElement._originalTextContent = "\"" + description + "\"";
             } else if (this.property.value.type === "function" && typeof description === "string") {
-                this.valueElement.textContent = /.*/.exec(description)[0].replace(/ +$/g, "");
+                var text = /.*/.exec(description)[0].replace(/ +$/g, "");
+                this.valueElement.setTextContentTruncatedIfNeeded(text);
                 this.valueElement._originalTextContent = description;

[pfeldman, 2014/03/05 05:14:03]

Accidental click will start editing the original. Consider replacing it with
"<string is too large to edit>" placeholder.

[aandrey, 2014/03/05 10:47:35]

Done.

             } else if (this.property.value.type !== "object" || this.property.value.subtype !== "node") {
-                this.valueElement.textContent = description;
+                this.valueElement.setTextContentTruncatedIfNeeded(description);
             }
 
             if (this.property.wasThrown)
                 this.valueElement.classList.add("error");
             if (this.property.value.subtype)
                 this.valueElement.classList.add("console-formatted-" + this.property.value.subtype);
             else if (this.property.value.type)
                 this.valueElement.classList.add("console-formatted-" + this.property.value.type);
 
             this.valueElement.addEventListener("contextmenu", this._contextMenuFired.bind(this, this.property.value), false);
@@ skipping 81 matching lines @@
     {
         var elementAndValueToEdit = this.elementAndValueToEdit(event);
         var elementToEdit = elementAndValueToEdit[0];
         var valueToEdit = elementAndValueToEdit[1];
 
         if (WebInspector.isBeingEdited(elementToEdit) || !this.treeOutline.section.editable || this._readOnly)
             return;
 
         // Edit original source.
         if (typeof valueToEdit !== "undefined")
-            elementToEdit.textContent = valueToEdit;
+            elementToEdit.setTextContentTruncatedIfNeeded(valueToEdit);
 
         var context = { expanded: this.expanded, elementToEdit: elementToEdit, previousContent: elementToEdit.textContent };
 
         // Lie about our children to prevent expanding on double click and to collapse subproperties.
         this.hasChildren = false;
 
         this.listItemElement.classList.add("editing-sub-part");
 
         this._prompt = new WebInspector.ObjectPropertyPrompt(this.editingCommitted.bind(this, null, elementToEdit.textContent, context.previousContent, context), this.editingCancelled.bind(this, null, context), this.renderPromptAsBlock());
 
@@ skipping 649 matching lines @@
 {
     WebInspector.TextPrompt.call(this, WebInspector.runtimeModel.completionsForTextPrompt.bind(WebInspector.runtimeModel));
     this.setSuggestBoxEnabled("generic-suggest");
     if (renderAsBlock)
         this.renderAsBlock();
 }
 
 WebInspector.ObjectPropertyPrompt.prototype = {
     __proto__: WebInspector.TextPrompt.prototype
 }