Issue 186693002: DevTools: Prevent setting huge textContent in UI.

Issue 186693002: DevTools: Prevent setting huge textContent in UI. (Closed)

Created:
6 years, 9 months ago by aandrey

Modified:
6 years, 9 months ago

Reviewers:
pfeldman, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Prevent setting huge textContent in UI. Huge texts reduce rendering performance drastically, nor they are more helpful than a truncated version. BUG=347917 R=pfeldman, loislo Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168545

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : addressed #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -6 lines)			Patch
	M	Source/devtools/front_end/DOMExtension.js	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
	M	Source/devtools/front_end/ObjectPropertiesSection.js	View	1 2	2 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/186693002/diff/20001/Source/devtools/front_end/ObjectPropertiesSection.js File Source/devtools/front_end/ObjectPropertiesSection.js (left): https://codereview.chromium.org/186693002/diff/20001/Source/devtools/front_end/ObjectPropertiesSection.js#oldcode215 Source/devtools/front_end/ObjectPropertiesSection.js:215: this.valueElement._originalTextContent = description; Accidental click will start editing ...

6 years, 9 months ago (2014-03-05 05:14:02 UTC) #2

aandrey

https://codereview.chromium.org/186693002/diff/20001/Source/devtools/front_end/ObjectPropertiesSection.js File Source/devtools/front_end/ObjectPropertiesSection.js (left): https://codereview.chromium.org/186693002/diff/20001/Source/devtools/front_end/ObjectPropertiesSection.js#oldcode215 Source/devtools/front_end/ObjectPropertiesSection.js:215: this.valueElement._originalTextContent = description; On 2014/03/05 05:14:03, pfeldman wrote: > ...

6 years, 9 months ago (2014-03-05 10:47:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/186693002/30001

6 years, 9 months ago (2014-03-05 10:51:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/186693002/30001

6 years, 9 months ago (2014-03-05 20:57:54 UTC) #6

Message was sent while issue was closed.

Change committed as 168545

Expand Messages | Collapse Messages