Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1866893002: Enable IOSurface2DCanvasWebGL and 2DCanvasWebGL pixel tests. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable IOSurface2DCanvasWebGL and 2DCanvasWebGL pixel tests. The reference images have been made by the bots. BUG=595063 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/cfc49cf736c1b7d5879669b17a7dc68893f573d2 Cr-Commit-Position: refs/heads/master@{#385895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
erikchen
Manually verified from one recent build: https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Release%20%28AMD%29/builds/5104 https://chromium-swarm.appspot.com/user/task/2e06cf057b3f6b10 That new references images look right: gs://chromium-gpu-archive/reference-images/Pixel_IOSurface2DCanvasWebGL_v2_mac_1002_6821_msaa.png ...
4 years, 8 months ago (2016-04-07 00:11:13 UTC) #2
erikchen
kbr: Please review.
4 years, 8 months ago (2016-04-07 00:12:14 UTC) #4
Ken Russell (switch to Gerrit)
Please add BUG=595063 (if no other one is better) to the CL description. Thanks. LGTM
4 years, 8 months ago (2016-04-07 18:49:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866893002/1
4 years, 8 months ago (2016-04-07 18:57:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 22:09:08 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 22:11:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfc49cf736c1b7d5879669b17a7dc68893f573d2
Cr-Commit-Position: refs/heads/master@{#385895}

Powered by Google App Engine
This is Rietveld 408576698