[wasm] Adding metrics for Asm/Wasm.

src/counters.h

Index: src/counters.h
diff --git a/src/counters.h b/src/counters.h
index 7183d0e52e512876d38d793d91f9a6dbe1038406..8adb951354d7950dface423b05f3c1e273ca4422 100644
--- a/src/counters.h
+++ b/src/counters.h
@@ -588,7 +588,9 @@ class RuntimeCallTimerScope {
      101)                                                                     \
   HR(code_cache_reject_reason, V8.CodeCacheRejectReason, 1, 6, 6)             \
   HR(errors_thrown_per_context, V8.ErrorsThrownPerContext, 0, 200, 20)        \
-  HR(debug_feature_usage, V8.DebugFeatureUsage, 1, 7, 7)
+  HR(debug_feature_usage, V8.DebugFeatureUsage, 1, 7, 7)                      \
+  /* Asm/Wasm. */                                                             \
+  HR(wasm_functions_per_module, V8.WasmFunctionsPerModule, 0, 10000, 101)
 
 #define HISTOGRAM_TIMER_LIST(HT)                                              \
   /* Garbage collection timers. */                                            \
@@ -619,8 +621,17 @@ class RuntimeCallTimerScope {
   HT(compile_deserialize, V8.CompileDeserializeMicroSeconds, 1000000,         \
      MICROSECOND)                                                             \
   /* Total compilation time incl. caching/parsing */                          \
-  HT(compile_script, V8.CompileScriptMicroSeconds, 1000000, MICROSECOND)
-
+  HT(compile_script, V8.CompileScriptMicroSeconds, 1000000, MICROSECOND)      \
+  /* Asm/Wasm */                                                              \
+  HT(wasm_instantiate_time, V8.WasmInstantiateMicroSeconds, 1000000,          \
+     MICROSECOND)                                                             \
+  HT(wasm_decode_module_time, V8.WasmDecodeModuleMicroSeconds, 1000000,       \
+     MICROSECOND)                                                             \
+  HT(wasm_decode_function_time, V8.WasmDecodeFunctionMicroSeconds, 1000000,   \
+     MICROSECOND)                                                             \
+  HT(wasm_compile_time, V8.WasmCompileMicroSeconds, 1000000, MICROSECOND)     \
+  HT(wasm_compile_function_time, V8.WasmCompileFunctionMicroSeconds, 1000000, \
+     MICROSECOND)
 
 #define AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT) \
   AHT(compile_lazy, V8.CompileLazyMicroSeconds)
@@ -651,10 +662,16 @@ class RuntimeCallTimerScope {
   HM(heap_sample_code_space_committed, V8.MemoryHeapSampleCodeSpaceCommitted) \
   HM(heap_sample_maximum_committed, V8.MemoryHeapSampleMaximumCommitted)
 
-#define HISTOGRAM_MEMORY_LIST(HM)                   \
-  HM(memory_heap_committed, V8.MemoryHeapCommitted) \
-  HM(memory_heap_used, V8.MemoryHeapUsed)
-
+#define HISTOGRAM_MEMORY_LIST(HM)                                         \
+  HM(memory_heap_committed, V8.MemoryHeapCommitted)                       \
+  HM(memory_heap_used, V8.MemoryHeapUsed)                                 \
+  /* Asm/Wasm */                                                          \
+  HM(wasm_decode_peak_memory, V8.WasmDecodePeakMemory)                    \
+  HM(wasm_compile_function_peak_memory, V8.WasmCompileFunctionPeakMemory) \
+  HM(wasm_min_mem_pages_memory, V8.WasmMinMemPagesMemory)                 \
+  HM(wasm_max_mem_pages_memory, V8.WasmMaxMemPagesMemory)                 \
+  HM(wasm_function_bytes, V8.WasmFunctionBytes)                           \

[Mircea Trofin, 2016/04/13 17:51:25]

Nit: wasm_{min|max}_mem_pages_memory has the word "memory" twice (once
abbreviated, true). wasm_function_bytes isn't the bytes of the function, but its
size in bytes, I assume.

How about:
wasm_{decode|compile}_function_peak_memory_bytes
wasm_{min|max}_mem_pages_count (if we just count pages)
wasm_function_size_bytes

[bradnelson, 2016/04/14 07:05:22]

Changed, although leaving wasm_decode_function_peak_memory_bytes, as we share a
single
zone for decoding (no memory allocation in decoding function bodies).

+  HM(wasm_module_bytes, V8.WasmModuleBytes)
 
 // WARNING: STATS_COUNTER_LIST_* is a very large macro that is causing MSVC
 // Intellisense to crash.  It was broken into two macros (each of length 40
@@ -703,7 +720,6 @@ class RuntimeCallTimerScope {
   /* The store-buffer implementation of the write barrier. */         \
   SC(store_buffer_overflows, V8.StoreBufferOverflows)
 
-
 #define STATS_COUNTER_LIST_2(SC)                                               \
   /* Number of code stubs. */                                                  \
   SC(code_stubs, V8.CodeStubs)                                                 \
@@ -763,7 +779,7 @@ class RuntimeCallTimerScope {
   SC(math_pow_runtime, V8.MathPowRuntime)                                      \
   SC(stack_interrupts, V8.StackInterrupts)                                     \
   SC(runtime_profiler_ticks, V8.RuntimeProfilerTicks)                          \
-  SC(runtime_calls, V8.RuntimeCalls)                          \
+  SC(runtime_calls, V8.RuntimeCalls)                                           \
   SC(bounds_checks_eliminated, V8.BoundsChecksEliminated)                      \
   SC(bounds_checks_hoisted, V8.BoundsChecksHoisted)                            \
   SC(soft_deopts_requested, V8.SoftDeoptsRequested)                            \