Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1866853002:
Add the Nordic and TI firmware update services to the Bluetooth blacklist. (Closed)
|
Created:
4 years, 8 months ago by Jeffrey Yasskin Modified:
4 years, 8 months ago Reviewers:
scheib CC:
chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd the Nordic and TI firmware update services to the Bluetooth blacklist.
Added upstream in https://github.com/WebBluetoothCG/registries/pull/9.
BUG=601227
Committed: https://crrev.com/2b3d607e7a193d0e4e350eb06c1cc6846e299056
Cr-Commit-Position: refs/heads/master@{#385795}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Update and move the updated date. #
Messages
Total messages: 24 (11 generated)
The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run
jyasskin@chromium.org changed reviewers: + scheib@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866853002/1
Description was changed from ========== Add the Nordic and TI firmware update services to the Bluetooth blacklist. Added upstream in https://github.com/WebBluetoothCG/registries/pull/9. ========== to ========== Add the Nordic and TI firmware update services to the Bluetooth blacklist. Added upstream in https://github.com/WebBluetoothCG/registries/pull/9. BUG=601227 ==========
Added the bug for you.
On 2016/04/06 22:30:42, ortuno wrote: > Added the bug for you. Thanks; that was fast.
LGTM with nit: https://codereview.chromium.org/1866853002/diff/1/content/browser/bluetooth/b... File content/browser/bluetooth/bluetooth_blacklist.cc (right): https://codereview.chromium.org/1866853002/diff/1/content/browser/bluetooth/b... content/browser/bluetooth/bluetooth_blacklist.cc:139: // Blacklist UUIDs updated 2016-02-12 from: Updated date needs updating. Possibly to the current date. Possibly just removing it. Maybe moving it down closer to lines that change. Or maybe to just 2016-04-01.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1866853002/diff/1/content/browser/bluetooth/b... File content/browser/bluetooth/bluetooth_blacklist.cc (right): https://codereview.chromium.org/1866853002/diff/1/content/browser/bluetooth/b... content/browser/bluetooth/bluetooth_blacklist.cc:139: // Blacklist UUIDs updated 2016-02-12 from: On 2016/04/07 00:23:22, scheib wrote: > Updated date needs updating. Possibly to the current date. Possibly just > removing it. Maybe moving it down closer to lines that change. Or maybe to just > 2016-04-01. Done; moved it to next to the actual blacklist.
The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866853002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scheib@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org Link to the patchset: https://codereview.chromium.org/1866853002/#ps20001 (title: "Update and move the updated date.")
The CQ bit was unchecked by scheib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866853002/20001
The CQ bit was checked by scheib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866853002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add the Nordic and TI firmware update services to the Bluetooth blacklist. Added upstream in https://github.com/WebBluetoothCG/registries/pull/9. BUG=601227 ========== to ========== Add the Nordic and TI firmware update services to the Bluetooth blacklist. Added upstream in https://github.com/WebBluetoothCG/registries/pull/9. BUG=601227 Committed: https://crrev.com/2b3d607e7a193d0e4e350eb06c1cc6846e299056 Cr-Commit-Position: refs/heads/master@{#385795} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2b3d607e7a193d0e4e350eb06c1cc6846e299056 Cr-Commit-Position: refs/heads/master@{#385795} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
