Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: media/base/media_log.cc

Issue 186683002: Reland "Add base::TimeDelta::Max()" again. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remediate to review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/media_log.h ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.cc
diff --git a/media/base/media_log.cc b/media/base/media_log.cc
index 6e21cff485a902c2f91ff0489e4df026ca5ebe6a..c689d7a46cdd934207ea3f66891587dd6dcf7406 100644
--- a/media/base/media_log.cc
+++ b/media/base/media_log.cc
@@ -141,7 +141,10 @@ scoped_ptr<MediaLogEvent> MediaLog::CreateStringEvent(
scoped_ptr<MediaLogEvent> MediaLog::CreateTimeEvent(
MediaLogEvent::Type type, const char* property, base::TimeDelta value) {
scoped_ptr<MediaLogEvent> event(CreateEvent(type));
- event->params.SetDouble(property, value.InSecondsF());
+ if (value.is_max())
+ event->params.SetString(property, "unknown");
+ else
+ event->params.SetDouble(property, value.InSecondsF());
return event.Pass();
}
@@ -228,4 +231,14 @@ void MediaLog::SetBooleanProperty(
AddEvent(event.Pass());
}
+void MediaLog::SetTimeProperty(
+ const char* key, base::TimeDelta value) {
+ scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
+ if (value.is_max())
+ event->params.SetString(key, "unknown");
+ else
+ event->params.SetDouble(key, value.InSecondsF());
+ AddEvent(event.Pass());
+}
+
} //namespace media
« no previous file with comments | « media/base/media_log.h ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698