Reland "Add base::TimeDelta::Max()" again.

Reland "Add base::TimeDelta::Max()" again.

Webkit layout tests found more media logs serializing infinite
durations to JSON.

R=scherkus@chromium.org
TBR=ajwong@chromium.org,jar@chromium.org,jamesr@chomium.org,acolwell@chromium.org,nick@chromium.org
BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255128

[gavinp, 2014-03-04 14:44:10]

scherkus: PTAL.

We missed one of these in our last reland, but thankfully webkit tests on the
trunk caught it. See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%25...
for the failure.

I've now grepped users of MediaLog and read through more of the code with
durations. I believe we have them now. WDYT?

[gavinp, 2014-03-04 14:44:33]

Note: patch set 1 is what was landed before, so the 1->2 diffs are the fix to
the crash.

[scherkus (not reviewing), 2014-03-04 18:13:02]

lgtm w/ nit

https://codereview.chromium.org/186683002/diff/20001/media/filters/ffmpeg_dem...
File media/filters/ffmpeg_demuxer.cc (right):

https://codereview.chromium.org/186683002/diff/20001/media/filters/ffmpeg_dem...
media/filters/ffmpeg_demuxer.cc:737: media_log_->SetDoubleProperty("start_time",
start_time_.InSecondsF());
can you change this as well?

according to code search this is the only other instance where we are setting a
time value as a double:
https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/ffmp...

[gavinp, 2014-03-05 15:04:08]

On 2014/03/04 18:13:02, scherkus wrote:
> lgtm w/ nit
> 
>
https://codereview.chromium.org/186683002/diff/20001/media/filters/ffmpeg_dem...
> File media/filters/ffmpeg_demuxer.cc (right):
> 
>
https://codereview.chromium.org/186683002/diff/20001/media/filters/ffmpeg_dem...
> media/filters/ffmpeg_demuxer.cc:737:
media_log_->SetDoubleProperty("start_time",
> start_time_.InSecondsF());
> can you change this as well?
> 
> according to code search this is the only other instance where we are setting
a
> time value as a double:
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/ffmp...

I'm going to do your suggested changes in a separate CL. The reason is that this
cl is for TimeDelta::Max(), and the time for that double is a base::Time, a
slightly different beast. So I'll prepare and upload that CL, then land this one
with that one shortly after.

[gavinp, 2014-03-05 15:11:52]

On 2014/03/05 15:04:08, gavinp wrote:
> On 2014/03/04 18:13:02, scherkus wrote:
> > lgtm w/ nit
> > 
> >
>
https://codereview.chromium.org/186683002/diff/20001/media/filters/ffmpeg_dem...
> > File media/filters/ffmpeg_demuxer.cc (right):
> > 
> >
>
https://codereview.chromium.org/186683002/diff/20001/media/filters/ffmpeg_dem...
> > media/filters/ffmpeg_demuxer.cc:737:
> media_log_->SetDoubleProperty("start_time",
> > start_time_.InSecondsF());
> > can you change this as well?
> > 
> > according to code search this is the only other instance where we are
setting
> a
> > time value as a double:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/ffmp...
> 
> I'm going to do your suggested changes in a separate CL. The reason is that
this
> cl is for TimeDelta::Max(), and the time for that double is a base::Time, a
> slightly different beast. So I'll prepare and upload that CL, then land this
one
> with that one shortly after.

Nevermind the above. It seems start_time_ is a TimeDelta, so it belongs in this
CL. Thanks for the catch!

[gavinp, 2014-03-05 15:16:41]

https://codereview.chromium.org/186683002/diff/20001/media/filters/ffmpeg_dem...
File media/filters/ffmpeg_demuxer.cc (right):

https://codereview.chromium.org/186683002/diff/20001/media/filters/ffmpeg_dem...
media/filters/ffmpeg_demuxer.cc:737: media_log_->SetDoubleProperty("start_time",
start_time_.InSecondsF());
On 2014/03/04 18:13:02, scherkus wrote:
> can you change this as well?
> 
> according to code search this is the only other instance where we are setting
a
> time value as a double:
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/ffmp...

Done.

[gavinp, 2014-03-05 15:57:34]

The CQ bit was checked by gavinp@chromium.org

[commit-bot: I haz the power, 2014-03-05 15:58:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/186683002/30001

[commit-bot: I haz the power, 2014-03-05 20:02:09]

Change committed as 255128