Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 18668004: MIPS: Fix bug in StringConstructCode builtin. (Closed)

Created:
7 years, 5 months ago by dusmil
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix bug in StringConstructCode builtin. BUG= TEST=webkit/dfg-to-string-bad-toString, webkit/dfg-to-string-bad-valueOf, webkit/dfg-to-string-int-or-string, webkit/dfg-to-string-side-effect, webkit/dfg-to-string-bad-toString, webkit/dfg-to-string-bad-valueOf, webkit/dfg-to-string-toString-in-string, webkit/dfg-to-string-int, webkit/dfg-to-string-valueOf-in-string Committed: https://code.google.com/p/v8/source/detail?r=15489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips/builtins-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dusmil
7 years, 5 months ago (2013-07-04 11:53:10 UTC) #1
kisg
LGTM
7 years, 5 months ago (2013-07-04 14:03:35 UTC) #2
Yang
On 2013/07/04 14:03:35, kisg wrote: > LGTM LGTM.
7 years, 5 months ago (2013-07-04 15:04:23 UTC) #3
palfia
7 years, 5 months ago (2013-07-04 15:19:38 UTC) #4
Committed as r15489.

Powered by Google App Engine
This is Rietveld 408576698