SyncFS: Introduce SyncFileSystemBackend

webkit/browser/fileapi/file_system_mount_point_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_BROWSER_FILEAPI_FILE_SYSTEM_MOUNT_POINT_PROVIDER_H_
 #define WEBKIT_BROWSER_FILEAPI_FILE_SYSTEM_MOUNT_POINT_PROVIDER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/platform_file.h"
 #include "webkit/browser/fileapi/file_permission_policy.h"
 #include "webkit/browser/fileapi/open_file_system_mode.h"
+#include "webkit/browser/fileapi/task_runner_bound_observer_list.h"
 #include "webkit/browser/webkit_storage_browser_export.h"
 #include "webkit/common/fileapi/file_system_types.h"
 
 class GURL;
 
 namespace webkit_blob {
 class FileStreamReader;
 }
 
 namespace fileapi {
@@ skipping 18 matching lines @@
  public:
   // Callback for OpenFileSystem.
   typedef base::Callback<void(base::PlatformFileError error)>
       OpenFileSystemCallback;
   virtual ~FileSystemMountPointProvider() {}
 
   // Returns true if this mount point provider can handle |type|.
   // One mount point provider may be able to handle multiple filesystem types.
   virtual bool CanHandleType(FileSystemType type) const = 0;
 
+  // Returns the root URI for the given |origin_url| and |type|. It is ok to
+  // return an empty GURL if this mount point provider cannot handle |type|.
+  virtual GURL GetRootURI(const GURL& origin_url,
+                          FileSystemType type) const = 0;

[kinuko, 2013/07/08 12:31:20]

I don't think this is necessary here. (Please see the comment in
FileSystemContext::OpenFileSystem)

[nhiroki, 2013/07/22 04:34:14]

Removed.

+
   // Initializes the filesystem for the given |origin_url| and |type|.
   // This verifies if it is allowed to request (or create) the filesystem
   // and if it can access (or create) the root directory of the mount point.
   // If |mode| is CREATE_IF_NONEXISTENT calling this may also create
   // the root directory (and/or related database entries etc) for
   // the filesystem if it doesn't exist.
   virtual void OpenFileSystem(
       const GURL& origin_url,
       FileSystemType type,
       OpenFileSystemMode mode,
@@ skipping 43 matching lines @@
   // This method itself does *not* check if the given path exists and is a
   // regular file.
   virtual scoped_ptr<FileStreamWriter> CreateFileStreamWriter(
       const FileSystemURL& url,
       int64 offset,
       FileSystemContext* context) const = 0;
 
   // Returns the specialized FileSystemQuotaUtil for this mount point.
   // This could return NULL if this mount point does not support quota.
   virtual FileSystemQuotaUtil* GetQuotaUtil() = 0;
+
+  // Returns the update observers for this mount point. This could return NULL
+  // if update observer is not available in this mount point.
+  virtual const UpdateObserverList* GetUpdateObservers(
+      FileSystemType type) const = 0;

[kinuko, 2013/07/08 12:31:20]

Can we move this method out of FileSystemMountPointProvider but into QuotaUtil? 
This one's meaningful only in the sandboxed context (at least now) and I'm
trying to move all those sandbox-fs only methods to QuotaUtil. (So that
non-sandbox FS modules don't need to care about them)

Also can you move this change into a separate CL?

[nhiroki, 2013/07/22 04:34:14]

Done in http://crrev.com/211332/

 };
 
 // An interface to control external file system access permissions.
 class ExternalFileSystemMountPointProvider
     : public FileSystemMountPointProvider {
  public:
   // Returns true if |url| is allowed to be accessed.
   // This is supposed to perform ExternalFileSystem-specific security
   // checks.
   virtual bool IsAccessAllowed(const fileapi::FileSystemURL& url) const = 0;
@@ skipping 13 matching lines @@
         const std::string& extension_id) = 0;
   // Gets virtual path by known filesystem path. Returns false when filesystem
   // path is not exposed by this provider.
   virtual bool GetVirtualPath(const base::FilePath& file_system_path,
                               base::FilePath* virtual_path) = 0;
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_BROWSER_FILEAPI_FILE_SYSTEM_MOUNT_POINT_PROVIDER_H_