SyncFS: Introduce SyncFileSystemBackend

webkit/browser/fileapi/file_system_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/browser/fileapi/file_system_context.h"
 
 #include "base/bind.h"
 #include "base/single_thread_task_runner.h"
 #include "base/stl_util.h"
 #include "base/task_runner_util.h"
 #include "url/gurl.h"
 #include "webkit/browser/blob/file_stream_reader.h"
 #include "webkit/browser/fileapi/copy_or_move_file_validator.h"
 #include "webkit/browser/fileapi/external_mount_points.h"
 #include "webkit/browser/fileapi/file_permission_policy.h"
 #include "webkit/browser/fileapi/file_stream_writer.h"
 #include "webkit/browser/fileapi/file_system_file_util.h"
 #include "webkit/browser/fileapi/file_system_operation.h"
 #include "webkit/browser/fileapi/file_system_operation_runner.h"
 #include "webkit/browser/fileapi/file_system_options.h"
 #include "webkit/browser/fileapi/file_system_quota_client.h"
 #include "webkit/browser/fileapi/file_system_task_runners.h"
 #include "webkit/browser/fileapi/file_system_url.h"
 #include "webkit/browser/fileapi/isolated_context.h"
 #include "webkit/browser/fileapi/isolated_mount_point_provider.h"
 #include "webkit/browser/fileapi/mount_points.h"
 #include "webkit/browser/fileapi/sandbox_mount_point_provider.h"
-#include "webkit/browser/fileapi/syncable/local_file_change_tracker.h"
-#include "webkit/browser/fileapi/syncable/local_file_sync_context.h"
-#include "webkit/browser/fileapi/syncable/syncable_file_system_util.h"
 #include "webkit/browser/fileapi/test_mount_point_provider.h"
 #include "webkit/browser/quota/quota_manager.h"
 #include "webkit/browser/quota/special_storage_policy.h"
 #include "webkit/common/fileapi/file_system_util.h"
 
 using quota::QuotaClient;
 
 namespace fileapi {
 
 namespace {
@@ skipping 176 matching lines @@
   NOTREACHED() << "Unknown filesystem type: " << type;
   return NULL;
 }
 
 bool FileSystemContext::IsSandboxFileSystem(FileSystemType type) const {
   return GetQuotaUtil(type) != NULL;
 }
 
 const UpdateObserverList* FileSystemContext::GetUpdateObservers(
     FileSystemType type) const {
-  // Currently update observer is only available in SandboxMountPointProvider
-  // and TestMountPointProvider.
-  // TODO(kinuko): Probably GetUpdateObservers() virtual method should be
-  // added to FileSystemMountPointProvider interface and be called like
-  // other GetFoo() methods do.
-  if (sandbox_provider_->CanHandleType(type))
-    return sandbox_provider_->GetUpdateObservers(type);
-  if (type != kFileSystemTypeTest)
-    return NULL;
-  FileSystemMountPointProvider* mount_point_provider =
-      GetMountPointProvider(type);
-  return static_cast<TestMountPointProvider*>(
-      mount_point_provider)->GetUpdateObservers(type);
+  return GetMountPointProvider(type)->GetUpdateObservers(type);
 }
 
 const AccessObserverList* FileSystemContext::GetAccessObservers(
     FileSystemType type) const {
   // Currently access observer is only available in SandboxMountPointProvider.
   if (sandbox_provider_->CanHandleType(type))
     return sandbox_provider_->GetAccessObservers(type);
   return NULL;
 }
 
@@ skipping 18 matching lines @@
     const OpenFileSystemCallback& callback) {
   DCHECK(!callback.is_null());
 
   FileSystemMountPointProvider* mount_point_provider =
       GetMountPointProvider(type);
   if (!mount_point_provider) {
     callback.Run(base::PLATFORM_FILE_ERROR_SECURITY, std::string(), GURL());
     return;
   }
 
-  GURL root_url;
-  if (type == kFileSystemTypeSyncable)
-    root_url = sync_file_system::GetSyncableFileSystemRootURI(origin_url);
-  else
-    root_url = GetFileSystemRootURI(origin_url, type);
+  GURL root_url = mount_point_provider->GetRootURI(origin_url, type);

[kinuko, 2013/07/08 12:31:20]

Can't each mount point provider create the root_url (and name) and pass it to
the OpenFileSystem's callback on its own rather than create them here?

[nhiroki, 2013/07/22 04:34:14]

Done in http://crrev.com/211318/

   std::string name = GetFileSystemName(origin_url, type);
 
   mount_point_provider->OpenFileSystem(
       origin_url, type, mode,
       base::Bind(&DidOpenFileSystem, callback, root_url, name));
 }
 
 void FileSystemContext::DeleteFileSystem(
     const GURL& origin_url,
     FileSystemType type,
@@ skipping 43 matching lines @@
     int64 offset) {
   if (!url.is_valid())
     return scoped_ptr<FileStreamWriter>();
   FileSystemMountPointProvider* mount_point_provider =
       GetMountPointProvider(url.type());
   if (!mount_point_provider)
     return scoped_ptr<FileStreamWriter>();
   return mount_point_provider->CreateFileStreamWriter(url, offset, this);
 }
 
-void FileSystemContext::SetLocalFileChangeTracker(
-    scoped_ptr<sync_file_system::LocalFileChangeTracker> tracker) {
-  DCHECK(!change_tracker_.get());
-  DCHECK(tracker.get());
-  change_tracker_ = tracker.Pass();
-  sandbox_provider_->AddFileUpdateObserver(
-      kFileSystemTypeSyncable,
-      change_tracker_.get(),
-      task_runners_->file_task_runner());
-  sandbox_provider_->AddFileChangeObserver(
-      kFileSystemTypeSyncable,
-      change_tracker_.get(),
-      task_runners_->file_task_runner());
-}
-
-void FileSystemContext::set_sync_context(
-    sync_file_system::LocalFileSyncContext* sync_context) {
-  sync_context_ = sync_context;
-}
-
 FileSystemURL FileSystemContext::CrackURL(const GURL& url) const {
   return CrackFileSystemURL(FileSystemURL(url));
 }
 
 FileSystemURL FileSystemContext::CreateCrackedFileSystemURL(
     const GURL& origin,
     FileSystemType type,
     const base::FilePath& path) const {
   return CrackFileSystemURL(FileSystemURL(origin, type, path));
 }
 
 #if defined(OS_CHROMEOS) && defined(GOOGLE_CHROME_BUILD)
 void FileSystemContext::EnableTemporaryFileSystemInIncognito() {
   sandbox_provider_->set_enable_temporary_file_system_in_incognito(true);
 }
 #endif
 
 FileSystemContext::~FileSystemContext() {
-  task_runners_->file_task_runner()->DeleteSoon(
-      FROM_HERE, change_tracker_.release());
 }
 
 void FileSystemContext::DeleteOnCorrectThread() const {
   if (!task_runners_->io_task_runner()->RunsTasksOnCurrentThread() &&
       task_runners_->io_task_runner()->DeleteSoon(FROM_HERE, this)) {
     return;
   }
   delete this;
 }
 
@@ skipping 72 matching lines @@
     FileSystemType type = static_cast<FileSystemType>(t);
     if (provider->CanHandleType(type)) {
       const bool inserted = provider_map_.insert(
           std::make_pair(type, provider)).second;
       DCHECK(inserted);
     }
   }
 }
 
 }  // namespace fileapi