Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1866793003: Add methods to GPU extensions to precisely determine visual viewport dimensions. (Closed)

Created:
4 years, 8 months ago by bokan
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add methods to GPU extensions to precisely determine visual viewport properties. Gesture code in telemetry relies on the ability to calculate the bounding rect of an element within the visual viewport. It's currently incorrect because it doesn't have enough information to be able to calculate that. Namely, it needs to know the visual viewport's offset within the layout viewport. I've also added an explicit method for getting the page scale factor. Telemetry code currently uses window.outerWidth / window.innerWidth which *mostly* works but is a roundabout hack and has some edge cases. BUG=564008 Committed: https://crrev.com/7ef0e8bf2f09d4b2cbae994a944c99ac0eba56a7 Cr-Commit-Position: refs/heads/master@{#385894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M content/renderer/gpu/gpu_benchmarking_extension.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 3 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
bokan
Hi Avi, ptal.
4 years, 8 months ago (2016-04-07 16:24:37 UTC) #4
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-07 18:03:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866793003/1
4 years, 8 months ago (2016-04-07 18:04:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/193139)
4 years, 8 months ago (2016-04-07 19:15:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866793003/1
4 years, 8 months ago (2016-04-07 20:47:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 22:07:45 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 22:09:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ef0e8bf2f09d4b2cbae994a944c99ac0eba56a7
Cr-Commit-Position: refs/heads/master@{#385894}

Powered by Google App Engine
This is Rietveld 408576698