Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1866763003: libyuv: Add GN bots for Win,Mac,Linux,Android (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

libyuv: Add GN bots for Win,Mac,Linux,Android It turns out Linux and Android already had recipes created but no builders added. This adds the remaining recipes and sets up all bots on client.libyuv and tryserver.libyuv. BUG=601140 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299758

Patch Set 1 #

Patch Set 2 : Fix Android names #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -296 lines) Patch
M masters/master.client.libyuv/master_android_cfg.py View 2 chunks +4 lines, -0 lines 0 comments Download
M masters/master.client.libyuv/master_linux_cfg.py View 2 chunks +4 lines, -0 lines 0 comments Download
M masters/master.client.libyuv/master_mac_cfg.py View 2 chunks +4 lines, -0 lines 0 comments Download
M masters/master.client.libyuv/master_win_cfg.py View 2 chunks +4 lines, -0 lines 0 comments Download
M masters/master.client.libyuv/slaves.cfg View 4 chunks +8 lines, -0 lines 0 comments Download
M masters/master.tryserver.libyuv/master.cfg View 3 chunks +10 lines, -2 lines 0 comments Download
M masters/master.tryserver.libyuv/slaves.cfg View 4 chunks +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.py View 1 5 chunks +76 lines, -4 lines 0 comments Download
A + scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_gn.json View 1 1 chunk +0 lines, -121 lines 0 comments Download
D scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_gn__dbg_.json View 1 1 chunk +0 lines, -121 lines 0 comments Download
A + scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_release__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
A + scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac64_debug__gn_.json View 4 chunks +19 lines, -5 lines 0 comments Download
A + scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac64_release__gn_.json View 4 chunks +19 lines, -5 lines 0 comments Download
A + scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__gn_.json View 4 chunks +19 lines, -5 lines 0 comments Download
A + scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__gn_.json View 4 chunks +19 lines, -5 lines 1 comment Download
A + scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_gn.json View 4 chunks +19 lines, -5 lines 0 comments Download
A + scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_gn_rel.json View 4 chunks +20 lines, -8 lines 0 comments Download
A + scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_gn.json View 5 chunks +22 lines, -8 lines 0 comments Download
A + scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_gn_rel.json View 4 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866763003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866763003/20001
4 years, 8 months ago (2016-04-06 19:05:18 UTC) #4
kjellander_chromium
Frank: is Win64 enough or is 32-bit needed too?
4 years, 8 months ago (2016-04-06 19:05:23 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 19:13:08 UTC) #7
Michael Achenbach
lgtm https://codereview.chromium.org/1866763003/diff/20001/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__gn_.json File scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__gn_.json (right): https://codereview.chromium.org/1866763003/diff/20001/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__gn_.json#newcode73 scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__gn_.json:73: "--args=is_debug=false target_cpu=\"x64\" use_goma=true goma_dir=\"[BUILD]\\goma\"" Non-expert question: Guess component=static_library ...
4 years, 8 months ago (2016-04-06 19:17:21 UTC) #8
fbarchard1
On 2016/04/06 19:05:23, kjellander (chromium) wrote: > Frank: is Win64 enough or is 32-bit needed ...
4 years, 8 months ago (2016-04-06 22:01:07 UTC) #9
kjellander_chromium
On 2016/04/06 22:01:07, fbarchard1 wrote: > On 2016/04/06 19:05:23, kjellander (chromium) wrote: > > Frank: ...
4 years, 8 months ago (2016-04-07 06:47:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866763003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866763003/20001
4 years, 8 months ago (2016-04-07 06:47:28 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 06:51:50 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299758

Powered by Google App Engine
This is Rietveld 408576698