Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: pkg/analysis_server/test/completion_test.dart

Issue 1866753004: Code completion build fix following https://codereview.chromium.org/1860213002, fix test_all.dart t… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rebase with latest Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/test_all.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/completion_test.dart
diff --git a/pkg/analysis_server/test/completion_test.dart b/pkg/analysis_server/test/completion_test.dart
index f2cd2363877867f7571b3d1d6e8fa033ae89e55f..f2fb1510983feec698870dd28a35e52ab282a230 100644
--- a/pkg/analysis_server/test/completion_test.dart
+++ b/pkg/analysis_server/test/completion_test.dart
@@ -2655,19 +2655,20 @@ class Q {
!4part 'x';''',
<String>[
"1+library",
- "2+import",
- "3+export",
- "4+part",
+ "2+import \'\';",
+ "3+export \'\';",
+ "4+part \'\';",
"5+as",
"6+hide",
"7+show",
"8-null"
],
- failingTests: '567');
+ failingTests: '234567'); //TODO(jwren) 234 failing as correct selection
+ // offset assertions can't be passed into buildTests(..)
// keywords
buildTests('test018', '''!1part !2of foo;''', <String>["1+part", "2+of"],
- failingTests: '2');
+ failingTests: '12');
buildTests(
'test019',
« no previous file with comments | « no previous file | pkg/analysis_server/test/test_all.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698