Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1866753002: Add new timing mechanism to ftrace. (Closed)

Created:
4 years, 8 months ago by alexandermont
Modified:
4 years, 8 months ago
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add new timing mechanism to ftrace. Splits up the functionality of stopping tracing and getting the results, and performs the timing of how long to run the trace for in run_systrace.py instead of in the ftrace tracing agent itself. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f2e6ae857cbe690964d39c8d81bc0142209ef76c

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -27 lines) Patch
M systrace/systrace/run_systrace.py View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M systrace/systrace/tracing_agents/ftrace_agent.py View 1 2 3 4 chunks +5 lines, -19 lines 0 comments Download
M systrace/systrace/tracing_agents/ftrace_agent_unittest.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
alexandermont
4 years, 8 months ago (2016-04-06 18:29:44 UTC) #2
charliea (OOO until 10-5)
Thanks for breaking this apart Alex! This is much easier to review. non-owner lgtm w/ ...
4 years, 8 months ago (2016-04-06 18:42:51 UTC) #3
alexandermont
4 years, 8 months ago (2016-04-07 17:58:03 UTC) #4
nednguyen
https://codereview.chromium.org/1866753002/diff/20001/systrace/systrace/run_systrace.py File systrace/systrace/run_systrace.py (right): https://codereview.chromium.org/1866753002/diff/20001/systrace/systrace/run_systrace.py#newcode247 systrace/systrace/run_systrace.py:247: time.sleep(options.trace_time) Where does the keyboard interrupt logic go?
4 years, 8 months ago (2016-04-07 18:27:44 UTC) #5
alexandermont
4 years, 8 months ago (2016-04-07 18:51:34 UTC) #6
nednguyen
lgtm
4 years, 8 months ago (2016-04-07 19:17:18 UTC) #7
alexandermont
4 years, 8 months ago (2016-04-08 21:36:43 UTC) #8
Chris Craik
lgtm
4 years, 8 months ago (2016-04-11 17:29:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866753002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866753002/60001
4 years, 8 months ago (2016-04-11 17:34:10 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 17:49:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698