Source/bindings/scripts/v8_attributes.py - Issue 186673002: Support deprecation + use counters for constructor attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 186673002: Support deprecation + use counters for constructor attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased (UseCounter.h conflict) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 6af95ae469f84343c1992d6187e1035d3f8f0be8..d17018ab2ccf8ea5a41bf336a7b40051df2687c3 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -137,6 +137,7 @@ def generate_attribute(interface, attribute):

}

if is_constructor_attribute(attribute):

+ generate_constructor_getter(interface, attribute, contents)

return contents

if not has_custom_getter:

generate_getter(interface, attribute, contents)

@@ -396,3 +397,7 @@ def property_attributes(attribute):

def is_constructor_attribute(attribute):

return attribute.idl_type.endswith('Constructor')

+def generate_constructor_getter(interface, attribute, contents):

+ contents['needs_constructor_callback'] = contents['measure_as'] or contents['deprecate_as']

haraken 2014/03/05 14:34:57 needs_constructor_callback => needs_constructor_ge

sof 2014/03/05 14:56:45 Done.

« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | Source/bindings/templates/attributes.cpp » ('J')