Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp - Issue 186673002: Support deprecation + use counters for constructor attributes.

Unified Diff: Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

Issue 186673002: Support deprecation + use counters for constructor attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Always generate constructor getter callbacks Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/interface.cpp ('K') | « Source/bindings/tests/idls/TestObject.idl ('k') | Source/bindings/tests/results/V8TestInterfacePython.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

index 2769d731a3fb55b651fcd4c535f206e32992af21..f055a5ed3b7b56b5b2fc3dff401b2f15b92495f1 100644

--- a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

@@ -81,6 +81,13 @@ static void TestInterfaceNamedConstructorConstructorGetter(v8::Local<v8::String>

v8SetReturnValue(info, perContextData->constructorForType(WrapperTypeInfo::unwrap(data)));

}

+static void testNamedConstructorConstructorAttributeConstructorGetterCallback(v8::Local<v8::String> property, const v8::PropertyCallbackInfo<v8::Value>& info)

+ TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");

+ TestInterfaceNamedConstructorV8Internal::TestInterfaceNamedConstructorConstructorGetter(property, info);

+ TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");

static void TestInterfaceNamedConstructorReplaceableAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)

{

info.This()->ForceSet(name, jsValue);

@@ -94,7 +101,7 @@ static void TestInterfaceNamedConstructorReplaceableAttributeSetterCallback(v8::

} // namespace TestInterfaceNamedConstructorV8Internal

static const V8DOMConfiguration::AttributeConfiguration V8TestInterfaceNamedConstructorAttributes[] = {

- {"testNamedConstructorConstructorAttribute", TestInterfaceNamedConstructorV8Internal::TestInterfaceNamedConstructorConstructorGetter, TestInterfaceNamedConstructorV8Internal::TestInterfaceNamedConstructorReplaceableAttributeSetterCallback, 0, 0, const_cast<WrapperTypeInfo*>(&V8TestNamedConstructor::wrapperTypeInfo), static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::DontEnum), 0 /* on instance */},

+ {"testNamedConstructorConstructorAttribute", TestInterfaceNamedConstructorV8Internal::testNamedConstructorConstructorAttributeConstructorGetterCallback, TestInterfaceNamedConstructorV8Internal::TestInterfaceNamedConstructorReplaceableAttributeSetterCallback, 0, 0, const_cast<WrapperTypeInfo*>(&V8TestNamedConstructor::wrapperTypeInfo), static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::DontEnum), 0 /* on instance */},

};

const WrapperTypeInfo V8TestInterfaceNamedConstructorConstructor::wrapperTypeInfo = { gin::kEmbedderBlink, V8TestInterfaceNamedConstructorConstructor::domTemplate, V8TestInterfaceNamedConstructor::derefObject, V8TestInterfaceNamedConstructor::toActiveDOMObject, 0, 0, V8TestInterfaceNamedConstructor::installPerContextEnabledMethods, 0, WrapperTypeObjectPrototype, false };