Chromium Code Reviews

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 186673002: Support deprecation + use counters for constructor attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | Source/bindings/tests/idls/TestObject.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_attributes.py
diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py
index 6af95ae469f84343c1992d6187e1035d3f8f0be8..d17018ab2ccf8ea5a41bf336a7b40051df2687c3 100644
--- a/Source/bindings/scripts/v8_attributes.py
+++ b/Source/bindings/scripts/v8_attributes.py
@@ -137,6 +137,7 @@ def generate_attribute(interface, attribute):
}
if is_constructor_attribute(attribute):
+ generate_constructor_getter(interface, attribute, contents)
return contents
if not has_custom_getter:
generate_getter(interface, attribute, contents)
@@ -396,3 +397,7 @@ def property_attributes(attribute):
def is_constructor_attribute(attribute):
return attribute.idl_type.endswith('Constructor')
+
+
+def generate_constructor_getter(interface, attribute, contents):
+ contents['needs_constructor_callback'] = contents['measure_as'] or contents['deprecate_as']
« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | Source/bindings/tests/idls/TestObject.idl » ('J')

Powered by Google App Engine