third_party/WebKit/LayoutTests/svg/text/surrogate-pair-attribute-positions.html - Issue 1866703002: Use characters (not code units) when computing value list positions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/text/surrogate-pair-attribute-positions.html

Issue 1866703002: Use characters (not code units) when computing value list positions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-14

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg width="200" height="100">

	3 <style>

	4 @font-face {

	5 font-family: MyFont;

	6 src: url(../../third_party/adobe-fonts/CSSFWOrientationTest.otf);

	7 }

	8 </style>

	9 <text font-family="MyFont" font-size="50" x="0 100" y="50">𑀏<tspan>&#x 1100F;</tspan></text>

	10 <script>

	11 document.body.offsetLeft; // Kick off loading @font-face
	pdr. 2016/04/06 18:10:57 Is the test really flaky without this? I know we h Is the test really flaky without this? I know we had this issue with Ahem, but there have been some loading changes lately and I wonder if it's still needed. Is there any way we can generalize this in a helper js file? fs 2016/04/06 18:21:14 I guess this was a "better safe than sorry" from m Show quoted text On 2016/04/06 at 18:10:57, pdr wrote: > Is the test really flaky without this? I know we had this issue with Ahem, but there have been some loading changes lately and I wonder if it's still needed. > > Is there any way we can generalize this in a helper js file? I guess this was a "better safe than sorry" from my side (but these issue never really showed up on my dev. platform before either...) I guess we can take it out and see what happens. I was pondering something like: <script src="font-loader.js" data-family="MyFont" data-font-src="...otf"></script> and use the Font Loading API. But it did feel like overkill for a single test. (Don't know how many others there are that might be interested in something like it.)
	12 if (window.testRunner) {

	13 testRunner.waitUntilDone();

	14 document.body.onload = function () { testRunner.notifyDone(); };

	15 }

	16 </script>

	17 </svg>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/text/surrogate-pair-attribute-positions-expected.html » ('j') | no next file with comments »