Allow to pass a user message to assert functions

test/intl/assert.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 69 matching lines @@
     }
     return true;
   }
   if (objectClass == 'String' || objectClass == 'Number' ||
       objectClass == 'Boolean' || objectClass == 'Date') {
     if (a.valueOf() !== b.valueOf()) return false;
   }
   return deepObjectEquals(a, b);
 }
 
-
 /**
- * Throws an exception, and prints the values in case of error.
+ * Throws an exception containing the user_message (if any) and the values.
  */
-function fail(expected, found) {
+function fail(expected, found, user_message = '') {
   // TODO(cira): Replace String with PrettyPrint for objects and arrays.
-  var message = 'Failure: expected <' + String(expected) + '>, found <' +
-      String(found) + '>.';
+  var message = 'Failure' + (user_message ? ' (' + user_message + ')' : "") +

[JF, 2016/04/06 17:00:20]

Mixing single and double quotes is odd :-)

[Clemens Hammacher, 2016/04/07 07:42:52]

Done.

+      ': expected <' + String(expected) + '>, found <' + String(found) + '>.';
   throw new Error(message);
 }
 
 
 /**
  * Throws if two variables have different types or values.
  */
-function assertEquals(expected, found) {
+function assertEquals(expected, found, user_message = '') {
   if (!deepEquals(expected, found)) {
-    fail(expected, found);
+    fail(expected, found, user_message);
   }
 }
 
 
 /**
  * Throws if value is false.
  */
-function assertTrue(value) {
-  assertEquals(true, value)
+function assertTrue(value, user_message = '') {
+  assertEquals(true, value, user_message);
 }
 
 
 /**
  * Throws if value is true.
  */
-function assertFalse(value) {
-  assertEquals(false, value);
+function assertFalse(value, user_message = '') {
+  assertEquals(false, value, user_message);
 }
 
 
 /**
- * Returns true if code throws specified exception.
+ * Returns if the code throws the specified exception, throws otherwise.

[titzer, 2016/04/06 18:22:10]

You can just reword to "Runs {code} and asserts that it throws the specified
exception"

[Clemens Hammacher, 2016/04/07 07:42:52]

Done.

  */
 function assertThrows(code, type_opt, cause_opt) {
   var threwException = true;

[titzer, 2016/04/06 18:22:10]

I just noticed this variable is dead.

[Clemens Hammacher, 2016/04/07 07:42:52]

Right, I will remove it.

   try {
     if (typeof code == 'function') {
       code();
     } else {
       eval(code);
     }
     threwException = false;
   } catch (e) {
     if (typeof type_opt == 'function') {
       assertInstanceof(e, type_opt);
     }
     if (arguments.length >= 3) {
-      assertEquals(e.type, cause_opt);
+      assertEquals(cause_opt, e.type, 'thrown exception type mismatch');
     }
     // Success.
     return;
   }
-  throw new Error("Did not throw exception");
+  var expected = arguments.length >= 3 ? cause_opt :
+      typeof type_opt == 'function' ? type_opt : 'any exception';
+  fail(expected, "no exception", "expected thrown exception");
 }
 
 
 /**
  * Throws an exception if code throws.

[titzer, 2016/04/06 18:22:10]

You can reword this similarly. "Runs {code} and asserts that it does not throw
any exceptions"

[Clemens Hammacher, 2016/04/07 07:42:52]

Done.

  */
-function assertDoesNotThrow(code, name_opt) {
+function assertDoesNotThrow(code, user_message = '') {
   try {
     if (typeof code == 'function') {
       code();
     } else {
       eval(code);
     }
   } catch (e) {
-    fail("threw an exception: ", e.message || e, name_opt);
+    fail("no expection", "exception: " + String(e), user_message);
   }
 }
 
 
 /**
  * Throws if obj is not of given type.
  */
 function assertInstanceof(obj, type) {
   if (!(obj instanceof type)) {
     var actualTypeName = null;
     var actualConstructor = Object.prototypeOf(obj).constructor;
     if (typeof actualConstructor == "function") {
       actualTypeName = actualConstructor.name || String(actualConstructor);
     }
     throw new Error('Object <' + obj + '> is not an instance of <' +
          (type.name || type) + '>' +
          (actualTypeName ? ' but of < ' + actualTypeName + '>' : ''));
   }
 }