Allow to pass a user message to assert functions

Allow to pass a user message to assert functions

Nothing too important, but it helps localizing the cause of an error
much faster.
By the way, I also changed the output for assertThrows and
assertDoesNotThrow a bit.
All new arguments are optional, so everything is backwards compatible.

R=jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/b4edd2f6587d42f003a84fe87a137f13415d8542
Cr-Commit-Position: refs/heads/master@{#35322}

[JF, 2016-04-06 17:00:21]

lgtm otherwise

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js
File test/intl/assert.js (right):

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js#newcode95
test/intl/assert.js:95: var message = 'Failure' + (user_message ? ' (' +
user_message + ')' : "") +
Mixing single and double quotes is odd :-)

[titzer, 2016-04-06 18:22:11]

lgtm

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js
File test/intl/assert.js (right):

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js#newcode128
test/intl/assert.js:128: * Returns if the code throws the specified exception,
throws otherwise.
You can just reword to "Runs {code} and asserts that it throws the specified
exception"

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js#newcode131
test/intl/assert.js:131: var threwException = true;
I just noticed this variable is dead.

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js#newcode156
test/intl/assert.js:156: * Throws an exception if code throws.
You can reword this similarly. "Runs {code} and asserts that it does not throw
any exceptions"

[Clemens Hammacher, 2016-04-07 07:42:52]

Thanks for the comments.
I will upload a new patch and commit it right away (as there are no semantical
changes).

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js
File test/intl/assert.js (right):

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js#newcode95
test/intl/assert.js:95: var message = 'Failure' + (user_message ? ' (' +
user_message + ')' : "") +
On 2016/04/06 17:00:20, JF wrote:
> Mixing single and double quotes is odd :-)

Done.

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js#newcode128
test/intl/assert.js:128: * Returns if the code throws the specified exception,
throws otherwise.
On 2016/04/06 18:22:10, titzer wrote:
> You can just reword to "Runs {code} and asserts that it throws the specified
> exception"

Done.

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js#newcode131
test/intl/assert.js:131: var threwException = true;
On 2016/04/06 18:22:10, titzer wrote:
> I just noticed this variable is dead.

Right, I will remove it.

https://codereview.chromium.org/1866693002/diff/1/test/intl/assert.js#newcode156
test/intl/assert.js:156: * Throws an exception if code throws.
On 2016/04/06 18:22:10, titzer wrote:
> You can reword this similarly. "Runs {code} and asserts that it does not throw
> any exceptions"

Done.

[Clemens Hammacher, 2016-04-07 07:51:24]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-04-07 07:51:24]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
jfb@chromium.org
Link to the patchset: https://codereview.chromium.org/1866693002/#ps20001
(title: "Address comments, no semantical changes")

[commit-bot: I haz the power, 2016-04-07 07:51:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866693002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866693002/20001

[commit-bot: I haz the power, 2016-04-07 08:14:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-07 08:16:12]

Description was changed from

==========
Allow to pass a user message to assert functions

Nothing too important, but it helps localizing the cause of an error
much faster.
By the way, I also changed the output for assertThrows and
assertDoesNotThrow a bit.
All new arguments are optional, so everything is backwards compatible.

R=jfb@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
Allow to pass a user message to assert functions

Nothing too important, but it helps localizing the cause of an error
much faster.
By the way, I also changed the output for assertThrows and
assertDoesNotThrow a bit.
All new arguments are optional, so everything is backwards compatible.

R=jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/b4edd2f6587d42f003a84fe87a137f13415d8542
Cr-Commit-Position: refs/heads/master@{#35322}
==========

[commit-bot: I haz the power, 2016-04-07 08:16:13]

Patchset 2 (id:??) landed as
https://crrev.com/b4edd2f6587d42f003a84fe87a137f13415d8542
Cr-Commit-Position: refs/heads/master@{#35322}