Reland: Switch components/password_manager code from IPC messages to Mojo.

Reland: Switch components/password_manager code from IPC messages to Mojo.

Original CL was found breaking android gn build after landed.. #strange
Fix BUILD.gn and reland.

The original CL:
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391
Committed: https://crrev.com/4a2f71f4c9e9e2c3ac0e4622c12e5dc0c5ebfe24
Cr-Commit-Position: refs/heads/master@{#386290}

[leonhsl(Using Gerrit), 2016-04-06 05:58:53]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 05:59:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866643002/1

[commit-bot: I haz the power, 2016-04-06 06:12:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 06:12:22]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2016-04-06 10:38:09]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 10:38:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866643002/1

[commit-bot: I haz the power, 2016-04-06 10:47:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 10:47:41]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2016-04-06 23:40:17]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 23:42:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866643002/40001

[leonhsl(Using Gerrit), 2016-04-06 23:42:27]

Description was changed from

==========
Reland: Switch components/password_manager code from IPC messages to Mojo.

The original CL:
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391
==========

to

==========
Reland: Switch components/password_manager code from IPC messages to Mojo.

Original CL was found breaking android gn build after landed.. #strange
Fix BUILD.gn and reland.

The original CL:
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391
==========

[commit-bot: I haz the power, 2016-04-06 23:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 23:56:12]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2016-04-07 01:57:08]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 01:57:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866643002/40001

[commit-bot: I haz the power, 2016-04-07 02:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 02:11:53]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2016-04-07 03:40:50]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 03:41:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866643002/40001

[commit-bot: I haz the power, 2016-04-07 03:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 03:52:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2016-04-07 04:44:07]

leon.han@intel.com changed reviewers:
+ amistry@chromium.org, jochen@chromium.org, rockot@chromium.org,
tsepez@chromium.org, vabr@chromium.org

[leonhsl(Using Gerrit), 2016-04-07 04:44:07]

This CL fixed the android gn trybot failure caused by the original landed CL
https://codereview.chromium.org/1762603002/ , which has already been reverted.

ps#1 === the landed original CL, 
ps#2 === rebase only,
ps#3 === fixed the android gn trybot failure

Sorry would you please review again and I'll reland it then? Thanks~

[vabr (Chromium), 2016-04-07 11:42:57]

On 2016/04/07 04:44:07, leonhsl wrote:
> This CL fixed the android gn trybot failure caused by the original landed CL
> https://codereview.chromium.org/1762603002/ , which has already been reverted.
> 
> ps#1 === the landed original CL, 
> ps#2 === rebase only,
> ps#3 === fixed the android gn trybot failure
> 
> Sorry would you please review again and I'll reland it then? Thanks~

Rubberstamp LGTM for the change in
components/password_manager/content/public/interfaces/BUILD.gn.
Did you figure out which trybot would reproduce the buildbot failure (which got
the previous CL reverted)? Please make sure check that before relanding.

Thanks for carrying on with this, really appreciated!

Vaclav

[leonhsl(Using Gerrit), 2016-04-07 14:37:37]

On 2016/04/07 11:42:57, vabr (Chromium) wrote:
> On 2016/04/07 04:44:07, leonhsl wrote:
> > This CL fixed the android gn trybot failure caused by the original landed CL
> > https://codereview.chromium.org/1762603002/ , which has already been
reverted.
> > 
> > ps#1 === the landed original CL, 
> > ps#2 === rebase only,
> > ps#3 === fixed the android gn trybot failure
> > 
> > Sorry would you please review again and I'll reland it then? Thanks~
> 
> Rubberstamp LGTM for the change in
> components/password_manager/content/public/interfaces/BUILD.gn.
> Did you figure out which trybot would reproduce the buildbot failure (which
got
> the previous CL reverted)? Please make sure check that before relanding.
> 
> Thanks for carrying on with this, really appreciated!
> 
> Vaclav

Yeah the ps#1 reproduced the 'android_chromium_gn_compile_dbg' trybot failure,
and then confirmed that ps#3 fixed it. 
# Actually I reproduced the failure and confirmed the fix in my local machine
before uploading ps#3.

Thanks a lot for your great support ;-)

[Ken Rockot(use gerrit already), 2016-04-07 14:41:46]

lgtm

[jochen (gone - plz use gerrit), 2016-04-08 02:44:48]

lgtm

[Tom Sepez, 2016-04-08 15:26:03]

lgtm

[leonhsl(Using Gerrit), 2016-04-09 03:14:08]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-09 03:14:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866643002/60001

[commit-bot: I haz the power, 2016-04-09 04:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-09 04:21:37]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2016-04-09 06:40:29]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2016-04-09 06:40:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, jochen@chromium.org, vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1866643002/#ps60001
(title: "Rebase only")

[commit-bot: I haz the power, 2016-04-09 06:40:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866643002/60001

[commit-bot: I haz the power, 2016-04-09 06:46:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-09 06:48:50]

Description was changed from

==========
Reland: Switch components/password_manager code from IPC messages to Mojo.

Original CL was found breaking android gn build after landed.. #strange
Fix BUILD.gn and reland.

The original CL:
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391
==========

to

==========
Reland: Switch components/password_manager code from IPC messages to Mojo.

Original CL was found breaking android gn build after landed.. #strange
Fix BUILD.gn and reland.

The original CL:
https://crrev.com/d20fb918841354a75546fa38b5307aaba117598b

Original CL description follows:

Replace credential_manager_messages.h IPC to Mojo service.

BUG=582391

Committed: https://crrev.com/4a2f71f4c9e9e2c3ac0e4622c12e5dc0c5ebfe24
Cr-Commit-Position: refs/heads/master@{#386290}
==========

[commit-bot: I haz the power, 2016-04-09 06:48:51]

Patchset 4 (id:??) landed as
https://crrev.com/4a2f71f4c9e9e2c3ac0e4622c12e5dc0c5ebfe24
Cr-Commit-Position: refs/heads/master@{#386290}

[fs, 2016-04-09 16:12:29]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1872133002/ by fs@opera.com.

The reason for reverting is: Appears to have caused:

FAILED: /b/build/slave/GPU_Linux_Builder/build/src/build/goma/client/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/chrome/browser/test_support_ui/password_manager_test_base.o.d
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS
-DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_NSS_VERIFIER=1 -DUSE_X11=1
-DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1
-DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_TOPCHROME_MD=1
-DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=264915-1 -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER
-DTOOLKIT_VIEWS=1 -DGL_GLEXT_PROTOTYPES -DGTEST_HAS_POSIX_RE=0
-DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS
-DSK_SUPPORT_GPU=1 -DUNIT_TEST -I../.. -Igen
-I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0
-I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I../../third_party/protobuf/src -Igen/protoc_out
-I../../third_party/protobuf/src -I../../third_party/protobuf
-I../../third_party/khronos -I../../gpu -I../../testing/gtest/include
-I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nss
-I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nspr
-I../../third_party/boringssl/src/include -I../../testing/gmock/include
-I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c
-I../../third_party/skia/include/config -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/images
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables
-fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin
-fcolor-diagnostics
-fdebug-prefix-map=/b/build/slave/GPU_Linux_Builder/build/src=. -pthread -m64
-march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default
-Wno-deprecated-register -Wno-unneeded-internal-declaration
-Wno-inconsistent-missing-override -Wno-shift-negative-value -O2 -fno-ident
-fdata-sections -ffunction-sections -g0
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden
-Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang
follow-macro-expansion -Wheader-hygiene -Wstring-conversion -Wno-header-guard
-fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti
-fno-exceptions -c
../../chrome/browser/password_manager/password_manager_test_base.cc -o
obj/chrome/browser/test_support_ui/password_manager_test_base.o
In file included from
../../chrome/browser/password_manager/password_manager_test_base.cc:13:
In file included from
../../chrome/browser/password_manager/chrome_password_manager_client.h:15:
In file included from
../../components/password_manager/content/browser/credential_manager_impl.h:13:
In file included from
gen/components/password_manager/content/public/interfaces/credential_manager.mojom.h:26:
gen/components/password_manager/content/public/interfaces/credential_manager.mojom-internal.h:14:10:
fatal error: 'url/mojo/origin.mojom-internal.h' file not found
#include "url/mojo/origin.mojom-internal.h"

(https://build.chromium.org/p/chromium.gpu/builders/GPU%20Linux%20Builder/buil...).

[leonhsl(Using Gerrit), 2016-04-10 02:50:52]

On 2016/04/09 16:12:29, fs wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/1872133002/ by mailto:fs@opera.com.
> 
> The reason for reverting is: Appears to have caused:
> 
> FAILED: /b/build/slave/GPU_Linux_Builder/build/src/build/goma/client/gomacc
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> obj/chrome/browser/test_support_ui/password_manager_test_base.o.d
> -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1
-DENABLE_NOTIFICATIONS
> -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1
> -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
> -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1
> -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
> -DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_NSS_VERIFIER=1
-DUSE_X11=1
> -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1
> -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_SESSION_SERVICE=1
> -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
> -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_TOPCHROME_MD=1
> -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
> -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
> -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=264915-1
-D_FILE_OFFSET_BITS=64
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS
> -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
> -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER
> -DTOOLKIT_VIEWS=1 -DGL_GLEXT_PROTOTYPES -DGTEST_HAS_POSIX_RE=0
> -DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS
> -DSK_SUPPORT_GPU=1 -DUNIT_TEST -I../.. -Igen
> -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0
>
-I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -I../../third_party/protobuf/src -Igen/protoc_out
> -I../../third_party/protobuf/src -I../../third_party/protobuf
> -I../../third_party/khronos -I../../gpu -I../../testing/gtest/include
> -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nss
> -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nspr
> -I../../third_party/boringssl/src/include -I../../testing/gmock/include
> -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c
> -I../../third_party/skia/include/config -I../../third_party/skia/include/core
> -I../../third_party/skia/include/effects
-I../../third_party/skia/include/images
> -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
> -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe
> -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
> -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu
> -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
-funwind-tables
> -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin
> -fcolor-diagnostics
> -fdebug-prefix-map=/b/build/slave/GPU_Linux_Builder/build/src=. -pthread -m64
> -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers
> -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default
> -Wno-deprecated-register -Wno-unneeded-internal-declaration
> -Wno-inconsistent-missing-override -Wno-shift-negative-value -O2 -fno-ident
> -fdata-sections -ffunction-sections -g0
> --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden
> -Xclang -load -Xclang
> ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang
> -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs
> -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang
> follow-macro-expansion -Wheader-hygiene -Wstring-conversion -Wno-header-guard
> -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti
> -fno-exceptions -c
> ../../chrome/browser/password_manager/password_manager_test_base.cc -o
> obj/chrome/browser/test_support_ui/password_manager_test_base.o
> In file included from
> ../../chrome/browser/password_manager/password_manager_test_base.cc:13:
> In file included from
> ../../chrome/browser/password_manager/chrome_password_manager_client.h:15:
> In file included from
>
../../components/password_manager/content/browser/credential_manager_impl.h:13:
> In file included from
>
gen/components/password_manager/content/public/interfaces/credential_manager.mojom.h:26:
>
gen/components/password_manager/content/public/interfaces/credential_manager.mojom-internal.h:14:10:
> fatal error: 'url/mojo/origin.mojom-internal.h' file not found
> #include "url/mojo/origin.mojom-internal.h"
> 
>
(https://build.chromium.org/p/chromium.gpu/builders/GPU%20Linux%20Builder/buil...).

Hi, all, so sorry about this!! Brought additional work for all of you...
This bot is "GPU Linux Builder", seems it's not included in the checklist
trybots before landing??

I'll try to reproduce this failure locally and will land again once fix solution
done.. Thanks~

[leonhsl(Using Gerrit), 2016-04-12 05:37:51]

Patchset #5 (id:80001) has been deleted