Subzero: Remove a couple clumsy uses of snprintf.

src/IceInst.cpp

 //===- subzero/src/IceInst.cpp - High-level instruction implementation ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
 /// \brief Implements the Inst class, primarily the various subclass
 /// constructors and dump routines.
 ///
 //===----------------------------------------------------------------------===//
 
 #include "IceInst.h"
 
 #include "IceCfg.h"
 #include "IceCfgNode.h"
 #include "IceInstVarIter.h"
 #include "IceLiveness.h"
 #include "IceOperand.h"
 #include "IceTargetLowering.h"
 
+#include "llvm/Support/Format.h"
+
 namespace Ice {
 
 namespace {
 
 // Using non-anonymous struct so that array_lengthof works.
 const struct InstArithmeticAttributes_ {
   const char *DisplayString;
   bool IsCommutative;
 } InstArithmeticAttributes[] = {
 #define X(tag, str, commutative)                                               \
@@ skipping 584 matching lines @@
 
 // ======================== Dump routines ======================== //
 
 void Inst::dumpDecorated(const Cfg *Func) const {
   if (!BuildDefs::dump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   if (!Func->isVerbose(IceV_Deleted) && (isDeleted() || isRedundantAssign()))
     return;
   if (Func->isVerbose(IceV_InstNumbers)) {
-    char buf[30];
     InstNumberT Number = getNumber();
     if (Number == NumberDeleted)
-      snprintf(buf, llvm::array_lengthof(buf), "[XXX]");
+      Str << "[XXX]";
     else
-      snprintf(buf, llvm::array_lengthof(buf), "[%3d]", Number);
-    Str << buf;
+      Str << llvm::format("[%3d]", Number);
   }
   Str << "  ";
   if (isDeleted())
     Str << "  //";
   dump(Func);
   dumpExtras(Func);
   Str << "\n";
 }
 
 void Inst::dump(const Cfg *Func) const {
@@ skipping 410 matching lines @@
     // upper 32 bits of rax. We need to recognize and preserve these.
     return true;
   }
   if (!Dest->hasReg() && !SrcVar->hasReg() &&
       Dest->getStackOffset() == SrcVar->getStackOffset())
     return true;
   return false;
 }
 
 } // end of namespace Ice