Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1866633003: Subzero: Remove a couple clumsy uses of snprintf. (Closed)

Created:
4 years, 8 months ago by Jim Stichnoth
Modified:
4 years, 8 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Remove a couple clumsy uses of snprintf. We can use llvm::format() to achieve the same result in these cases. BUG= none R=jpp@chromium.org, kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d72385f28b49455ba5ac5e2386b1e4c8c27c79dd

Patch Set 1 #

Patch Set 2 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/IceInst.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceTimerTree.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
4 years, 8 months ago (2016-04-06 19:17:40 UTC) #3
Karl
lgtm
4 years, 8 months ago (2016-04-06 19:19:57 UTC) #4
John
lgtm
4 years, 8 months ago (2016-04-06 19:20:08 UTC) #5
Jim Stichnoth
4 years, 8 months ago (2016-04-06 19:21:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d72385f28b49455ba5ac5e2386b1e4c8c27c79dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698