Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1866633002: Make IPC::ParamTraits<>GetSize work with base::Value as a result of JSON parsing. (Closed)

Created:
4 years, 8 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make IPC::ParamTraits<>GetSize work with base::Value as a result of JSON parsing. The JSON parser uses a JSONStringValue for string values, which looks almost like a base::StringValue, but doesn't support GetAsString(base::StringValue**). BUG=597124 Committed: https://crrev.com/c7a7a767d643aef68eb2af82f961c11872abe59d Cr-Commit-Position: refs/heads/master@{#385989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M ipc/ipc_message_utils.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M ipc/ipc_message_utils_unittest.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Anand Mistry (off Chromium)
4 years, 8 months ago (2016-04-06 05:30:55 UTC) #2
Anand Mistry (off Chromium)
4 years, 8 months ago (2016-04-08 00:59:03 UTC) #5
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-08 02:15:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866633002/1
4 years, 8 months ago (2016-04-08 02:43:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 04:22:05 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 04:23:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7a7a767d643aef68eb2af82f961c11872abe59d
Cr-Commit-Position: refs/heads/master@{#385989}

Powered by Google App Engine
This is Rietveld 408576698